Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bookmarks refactor: simplying API for adding a new portal #725

Merged
merged 6 commits into from
Apr 19, 2024
Merged

Bookmarks refactor: simplying API for adding a new portal #725

merged 6 commits into from
Apr 19, 2024

Commits on Apr 18, 2024

  1. Factor out code common to bookmarking a specific portal.

    @modos189
    Mike Castle authored and modos189 committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    2e92e12 View commit details
    Browse the repository at this point in the history

  2. Migrate to new functions that set the portal details for bookmarks.

    @modos189
    Mike Castle authored and modos189 committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    b5845f0 View commit details
    Browse the repository at this point in the history

  3. Add jsdoc and mark older function as deprecated.

    @modos189
    Mike Castle authored and modos189 committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    2d838a3 View commit details
    Browse the repository at this point in the history

  4. Switch *Portals list* to use addPortalBookmarkByMarker().

    @modos189
    Mike Castle authored and modos189 committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    9aa7f70 View commit details
    Browse the repository at this point in the history

  5. Throw Error if guid could not be looked up.

    @modos189
    Mike Castle authored and modos189 committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    53a5dc1 View commit details
    Browse the repository at this point in the history

  6. Fix eslint

    @modos189
    modos189 committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    fad6e62 View commit details
    Browse the repository at this point in the history