Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uninstall session-counter cleanly #265

Merged
merged 1 commit into from
Oct 12, 2022
Merged

Conversation

cantsin
Copy link
Contributor

@cantsin cantsin commented Oct 11, 2022

Partially fulfills #261

  • moves .ini to service/ directory since that's where the windows service runs now
  • removes windows service log files when we're done
  • asks windows service to
    • stop
    • kill the process (if it's a zombie for whatever reason -- this happens often in my testing)
    • uninstall itself

I suspect for a clean uninstall of wireshark and npcap, we're going to have to adjust the installers. the \D option (as seen below) does nothing and we need to know where these are installing so we can call their respective uninstallers. so that's TBD.

@meenubhooshanan
Copy link
Contributor

Sounds good! Looks like we can create a future ticket for uninstalling wireshark and npcap (but I don't think this is high priority)

@meenubhooshanan meenubhooshanan merged commit 2da2cdf into main Oct 12, 2022
@meenubhooshanan meenubhooshanan deleted the windows-uninstall branch October 12, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants