-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the conditions to display image_url in Solr search results for file type #10886
base: develop
Are you sure you want to change the base?
Update the conditions to display image_url in Solr search results for file type #10886
Conversation
src/main/java/edu/harvard/iq/dataverse/ThumbnailServiceWrapper.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I made a small tweak to the release note. API tests didn't run so I'm holding on to this to see if they pass this time. They're running now.
📦 Pushed preview images as
🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
API tests didn't run. At standup @stevenwinship said he'd take a look (thanks): https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-10886/5/testReport/ |
I re-ran the tests and they all passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure enough! Thanks! Approved!
What this PR does / why we need it: fixes the conditions in which the visibility of the image_url field is included in the search results.
Which issue(s) this PR closes:#10875
Closes #10875
Special notes for your reviewer:
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here: No
Is there a release notes update needed for this change?: No
Additional documentation: See #10855