Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor Bug sending software name/version to DataCite #10919

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Minor Bug sending software name/version to DataCite #10919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c4cd4c
fix if statement body
qqmyers Oct 11, 2024
f1380b1
release note
qqmyers Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/release-notes/10919-minor-DataCiteXML-bugfix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
A minor bug fix was made to avoid sending a useless ", null" in the DataCiteXML sent to DataCite and in the DataCite export when a dataset has a metadata entry for "Software Name" and no entry for "Software Version". The bug fix will update datasets upon publication. Anyone with existing published datasets with this problem can be fixed by [pushing updated metadata to DataCite for affected datasets](https://guides.dataverse.org/en/6.4/admin/dataverses-datasets.html#update-metadata-for-a-published-dataset-at-the-pid-provider) and [re-exporting the dataset metadata](https://guides.dataverse.org/en/6.4/admin/metadataexport.html#batch-exports-through-the-api) or by following steps 9 and 10 in the v6.4 release notes to update and re-export all datasets.
2 changes: 1 addition & 1 deletion src/main/java/edu/harvard/iq/dataverse/pidproviders/doi/XmlMetadataTemplate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1317,8 +1317,8 @@ private void writeDescriptions(XMLStreamWriter xmlw, DvObject dvObject, boolean
}
if (StringUtils.isNotBlank(softwareName)) {
if (StringUtils.isNotBlank(softwareVersion)) {
softwareName = softwareName + ", " + softwareVersion;
}
softwareName = softwareName + ", " + softwareVersion;
descriptionsWritten = XmlWriterUtil.writeOpenTagIfNeeded(xmlw, "descriptions", descriptionsWritten);
XmlWriterUtil.writeFullElementWithAttributes(xmlw, "description", attributes, softwareName);
}
Expand Down
Loading