Skip to content

fix(build): filter InfiniOps adapters on every backend - #1534

Merged
voltjia merged 1 commit into
mainfrom
fix/filter-infiniops-adapters
Aug 25, 2026
Merged

fix(build): filter InfiniOps adapters on every backend#1534
voltjia merged 1 commit into
mainfrom
fix/filter-infiniops-adapters

Conversation

@voltjia

@voltjia voltjia commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • apply INFINI_OPS_OPS adapter filtering on every backend instead of only inside the Cambricon + ATen setup block
  • keep the Cambricon-specific torch_mlu ABI and include configuration scoped to Cambricon
  • preserve the existing fallback that excludes the paged-attention InfiniOps adapter when no operator selection is provided

Root cause

The adapter-filtering block was nested in the Cambricon + ATen condition, so NVIDIA and other backends compiled every *_infiniops.cc adapter even when ops.json selected only a subset. A linked InfiniOps library could then fail to load because an unselected adapter retained an unresolved operator reference.

Validation

  • git diff --check
  • exercised this exact change in the stacked NVIDIA validation using accelerator-dev/nvidia:latest and an ops.json-selected InfiniOps build
  • confirmed the unselected IndexSelect adapter no longer left an undefined InfiniOps reference
  • built and installed infinicore_cpp_api and _infinicore; the resulting Python package imported successfully

@voltjia
voltjia marked this pull request as ready for review August 25, 2026 08:36
@voltjia
voltjia requested a review from a team August 25, 2026 08:36
@voltjia
voltjia merged commit 19c8395 into main Aug 25, 2026
10 checks passed
@voltjia
voltjia deleted the fix/filter-infiniops-adapters branch August 25, 2026 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants