fix(ascend): correct rotary embedding handling - #952
Open
baominghelly wants to merge 5 commits into
Open
Conversation
Correct Ascend RoPE semantics and fall back to ACLNN for unsupported custom RMSNorm inputs.
This reverts commit a925fb8.
…-kernels Revert "fix(ascend): correct Llama operator edge cases"
baominghelly
force-pushed
the
fix/ascend-llama-kernels
branch
from
August 25, 2026 06:26
8adfcd1 to
223f9d4
Compare
wooway777
force-pushed
the
feat/ascend-llama-ops
branch
2 times, most recently
from
August 25, 2026 09:56
53d4408 to
1f3d182
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aclnnRotaryPositionEmbeddingcalls for query and optional key tensors.Motivation
The previous Ascend RoPE implementation used an ACLNN layout and semantic combination that produced incorrect query and key values. It also required a key tensor even though the operator interface permits query-only execution.
Type of Change
feat- new feature / new operator / new platformfix- bug fixperf- performance improvement (no behavioral change)refactor- code restructuring without behavior changetest- adding or fixing tests onlydocs- documentation onlybuild/ci- build system or CI configurationchore- tooling, formatting, or other non-code changes!in the Conventional Commits prefix or aBREAKING CHANGE:footer)Platforms Affected
WITH_CPU)WITH_NVIDIA)WITH_ILUVATAR)WITH_METAX)WITH_CAMBRICON)WITH_MOORE)WITH_ASCEND)WITH_TORCH)Smoke Test Result
Test Results on Supported Platforms
Full `pytest` output
Benchmark / Performance Impact
N/A. This is a correctness fix; performance was not benchmarked.
Notes for Reviewers
6b256e0ab0853d9e2a7ef059bac22c847bd02251andSOC_VERSION=Ascend910_9382.