fix(ascend): correct rotary embedding handling - #953
Merged
Conversation
baominghelly
marked this pull request as ready for review
August 26, 2026 03:18
voltjia
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RotaryEmbeddingimplementation to process query and optional key tensors independently withaclnnRotaryPositionEmbedding, then copy the results back to preserve in-place behavior.tests/test_rotary_embedding.pyto cover Ascend's supported forward full-dimension NeoX configuration for FP32, FP16, and BF16 with and without a key tensor.Motivation
The Ascend implementation on
masterrequires a key tensor and uses a joint rotary-position API/layout that does not preserve the expected full-dimension NeoX values. This also prevents the query-only execution permitted by the shared operator interface.Type of Change
feat— new feature / new operator / new platformfix— bug fixperf— performance improvement (no behavioral change)refactor— code restructuring without behavior changetest— adding or fixing tests onlydocs— documentation onlybuild/ci— build system or CI configurationchore— tooling, formatting, or other non-code changes!in the Conventional Commits prefix or aBREAKING CHANGE:footer)Platforms Affected
WITH_CPU)WITH_NVIDIA)WITH_ILUVATAR)WITH_METAX)WITH_CAMBRICON)WITH_MOORE)WITH_ASCEND)WITH_TORCH)Smoke Test Result
Test Results on Supported Platforms
Full `pytest` output
Benchmark / Performance Impact
N/A. This is a correctness fix; no performance benchmark was collected.
Notes for Reviewers
d57e5fe69c23c03e3e34aee2eb2e5e6bd30470f7, and the targeted test was rerun on the final branch.clang-formatwas unavailable in the CANN development container; formatting is deferred to CI.git diff --check, Ruff 0.15.22, the targeted build, and the targeted Ascend test passed.