fix: repair native example builds - #954
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WITH_CPUCMake variable whenno accelerator backend is selected, so raw CMake builds include the CPU
sources and dependencies.
kMemcpyHostToDeviceandkMemcpyDeviceToHostruntime constants.Motivation
Raw CMake builds exposed two inconsistent backend/runtime paths:
leaving the
WITH_CPUCMake variable disabled while backend sources wereselected.
kInfiniRT memcpyconstants, causing
gemmandgemm_dispatchto fail compilation.This restores the documented default CPU fallback and makes the examples
compatible with the current InfiniRT runtime API.
Type of Change
feat- new feature / new operator / new platformfix- bug fixperf- performance improvement (no behavioral change)refactor- code restructuring without behavior changetest- adding or fixing tests onlydocs- documentation onlybuild/ci- build system or CI configurationchore- tooling, formatting, or other non-code changes!in the Conventional Commits prefix or aBREAKING CHANGE:footer)Platforms Affected
WITH_CPU)WITH_NVIDIA)WITH_ILUVATAR)WITH_METAX)WITH_MARS)WITH_CAMBRICON)WITH_MOORE)WITH_ASCEND)WITH_TORCH)Smoke Test Result
Test Results on Supported Platforms
Full `pytest` output (optional)
Benchmark / Performance Impact
N/A. This is a build/configuration compatibility fix; no
performance-sensitive runtime path changes.
Notes for Reviewers
behavior.
member names.
commit. Both clean full builds/installations also passed.
NVIDIA-only GetCutlassMoeMmData binding but two generic precondition tests
do not skip CPU. NVIDIA additionally has 32 existing moe_wna16_gemm
numerical failures. Failed records then expose a separate tests/report.py
None/string sorting bug.
Ascend, and NVIDIA CI v2 shadow passed. Primary NVIDIA failed while pip
downloaded Ruff over SSL; Ascend shadow failed fetching the CI repository.
Cambricon hit an existing generated-code linker conflict, and Moore remains
pending.
their hardware is unavailable; backend CI/owner validation is required.