sonar

Informatievlaanderen · Nov 24, 2023 · 566b3f1 · 566b3f1
1 parent fb06d94
commit 566b3f1
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 13 deletions.
diff --git a/.github/workflows/pr-build.yml b/.github/workflows/pr-build.yml
@@ -30,4 +30,4 @@ jobs:
         if: ${{ github.actor != 'dependabot[bot]' && !github.event.pull_request.head.repo.fork }}
         env:
           SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
-        run: mvn -f ./backend/pom.xml -B verify org.sonarsource.scanner.maven:sonar-maven-plugin:sonar
+        run: mvn -f ./backend/pom.xml -B verify org.sonarsource.scanner.maven:sonar-maven-plugin:sonar -Pcoverage
diff --git a/backend/pom.xml b/backend/pom.xml
@@ -58,6 +58,15 @@
         <apache.sis-embedded-data.verion>1.3</apache.sis-embedded-data.verion>
         <apache.derby.version>10.14.2.0</apache.derby.version>
         <jsoup.version>1.16.1</jsoup.version>
+
+        <sonar.java.coveragePlugin>jacoco</sonar.java.coveragePlugin>
+        <sonar.dynamicAnalysis>reuseReports</sonar.dynamicAnalysis>
+        <sonar.coverage.jacoco.xmlReportPaths>${project.basedir}/target/site/jacoco/jacoco.xml
+        </sonar.coverage.jacoco.xmlReportPaths>
+        <sonar.language>java</sonar.language>
+        <sonar.host.url>https://sonarcloud.io</sonar.host.url>
+        <sonar.organization>informatievlaanderen</sonar.organization>
+        <sonar.projectKey>informatievlaanderen_vsds-demonstrator</sonar.projectKey>
     </properties>
 
     <dependencies>

diff --git a/pom.xml b/pom.xml
@@ -15,18 +15,6 @@
         <module>backend</module>
     </modules>
 
-    <properties>
-        <!-- Jacoco -->
-        <sonar.java.coveragePlugin>jacoco</sonar.java.coveragePlugin>
-        <sonar.dynamicAnalysis>reuseReports</sonar.dynamicAnalysis>
-        <sonar.coverage.jacoco.xmlReportPaths>${project.basedir}/target/site/jacoco/jacoco.xml
-        </sonar.coverage.jacoco.xmlReportPaths>
-        <sonar.language>java</sonar.language>
-        <sonar.host.url>https://sonarcloud.io</sonar.host.url>
-        <sonar.organization>informatievlaanderen</sonar.organization>
-        <sonar.projectKey>informatievlaanderen_vsds-demonstrator</sonar.projectKey>
-    </properties>
-
     <licenses>
         <license>
             <name>EUPL</name>