Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug-Fixes related to machines. #131

Open
wants to merge 3 commits into
base: 1.21
Choose a base branch
from
Open

Bug-Fixes related to machines. #131

wants to merge 3 commits into from

Conversation

Kanzaji
Copy link

@Kanzaji Kanzaji commented Oct 14, 2024

This PR will resolve issues mentioned in PR to Industrial Foregoing 😄

Changes

  • RedstoneManager will now also save ShouldWork state to NBT. This will prevent machines to work once on the world load before ShouldWork state is updated back to false.
  • ActiveTile's IFacingComponents will now all execute in a single work tick, instead of stopping on the first sucesssfull insertion.
  • SidedInventoryComponent will now try to push all extracted items, instead of giving up on the first slot and trying in the next tick.
  • SidedInventoryComponent will now correctly validate slots based on the stack limit (Math.min(SlotLimit, StackLimit), preventing situations where it's stuck at trying to push into a single full slot.
  • MultiInventoryComponent now provides correct slot indexes to the wrapped inventories on the item insertion check.

@Kanzaji
Resolve InnovativeOnlineIndustries/Industrial-Foregoing#1487
8171306
@Kanzaji
Resolve InnovativeOnlineIndustries/Industrial-Foregoing#1475 + Few Ch…
c76b126 
…anges

Sided inventories will now correctly check if the slot is valid - The stack limit is now Math.min(StackLimit, SlotLimit)

Sided Inventories will now try to transfer until they insert all items extracted, or until there are no more valid slots.

All IFacingComponents are now called per operation, instead of breaking on the first one that succeeded.
@Kanzaji
Possibly Resolve InnovativeOnlineIndustries/Industrial-Foregoing#1473
e9c47ec 
Can't reproduce original issue - however this fixes insertions to incorrect slots in locked inventories.
@Kanzaji Kanzaji mentioned this pull request Oct 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Kanzaji