Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Reduced main image size #4795

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

viv511
Copy link
Contributor

@viv511 viv511 commented Aug 3, 2024

Scaled original image by 50% in height and width. Changed because original image was too large.

Closes PR #4785

PR Checklist

  • No API changes were made (or the changes have been approved)
  • No major design changes were made (or the changes have been approved)
  • Added test (or behavior not changed)
  • Updated API documentation (or API not changed)
  • Added license to new files (if any)
  • Added Python wrapping to new files (if any) as described in ITK Software Guide Section 9.5
  • Added ITK examples for all new major features (if any)

Refer to the ITK Software Guide for
further development details if necessary.

Scaled original image by 50% in height and width. Changed because original image was too large.
@github-actions github-actions bot added type:Documentation Documentation improvement or change area:Documentation Issues affecting the Documentation module labels Aug 3, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing a pull request! 🙏

Welcome to the ITK community! 🤗👋☀️

We are glad you are here and appreciate your contribution. Please keep in mind our community participation guidelines. 📜
More support and guidance on the contribution process can be found in our contributing guide. 📖

This is an automatic message. Allow for time for the ITK community to be able to read the pull request and comment
on it.

Copy link
Member

@jhlegarreta jhlegarreta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO the image should have a fixed size: what if a new version of the logo that has a different size is added?

@viv511
Copy link
Contributor Author

viv511 commented Aug 4, 2024

Hi! Sure, I can add a new version of the logo with a different size. I used a HTML/CSS fix as per discussion in the original issue thread

@jhlegarreta
Copy link
Member

jhlegarreta commented Aug 4, 2024

Hi! Sure, I can add a new version of the logo with a different size. I used a HTML/CSS fix as #4785 (comment) in the original issue thread

I did not mean that we would need to add a logo with a different size; the issue probably arised because the new logo is much larger than the previous one, and if the situation repeats in the future the 50% width/height solution may be problematic. So IMO ideally we want the size of the displayed image be always the same (or have a fixed width or height, to respect its aspect ratio), regardless of the size of the logo in the original file.

@dzenanz
Copy link
Member

dzenanz commented Aug 5, 2024

ITK's logo does not change frequently. This PR improves the situation. Further improvements can be done in a follow-up PR, and/or when the logo is changed again.

@dzenanz dzenanz merged commit 4f675a2 into InsightSoftwareConsortium:master Aug 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:Documentation Issues affecting the Documentation module type:Documentation Documentation improvement or change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants