fix: do not clash ChunkHolder recycling with processors that extend outside the chunk #2353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dordsor21
commented
Jul 13, 2023
•
dordsor21
commented
- Extend getChunkLock usage to capture more operations on the chunks
- 5 ms grace period before recycling chunk
- unlock ChunkHolder sooner when being called (with copying both the set and (immediately) the get this can be done now)
- no longer a need for ReentrantWrappedStampedLock
SirYwell
requested changes
Jul 20, 2023
.../src/main/java/com/fastasyncworldedit/core/queue/implementation/SingleThreadQueueExtent.java
Outdated
Show resolved
Hide resolved
…utside the chunk - Extend getChunkLock usage to capture more operations on the chunks - 5 ms grace period before recycling chunk - unlock ChunkHolder sooner when being called (with copying both the set and (immediately) the get this can be done now) - not longer a need for ReentrantWrappedStampedLock
dordsor21
force-pushed
the
fix/no-bad-chunkholder-recycle
branch
from
5355189
to
6091f82
Compare
NotMyFault
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.