Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.21.3 #2974

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

1.21.3 #2974

wants to merge 6 commits into from
+8,199 −5

Conversation

PierreSchwang
Copy link
Member

Overview

1.21.3 support

Submitter Checklist
Beta Give feedback

@github-actions github-actions bot added the Feature This PR adds a new feature label Nov 1, 2024
@PierreSchwang
Copy link
Member Author

No issues so far, everything I've tested works as expected (property tab complete, masking, regen, modifying selections). Not sure if we want to add the new (1.21.4) block types and stuff as well (just like WE does in their 1.21.3 draft PR) or release 1.21.3 as is

dordsor21
dordsor21 reviewed Nov 2, 2024
View reviewed changes
Copy link
Member

@dordsor21 dordsor21 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably worth going for 1.20.3 first and then adding the .4 stuff as necessary

build.gradle.kts Outdated Show resolved Hide resolved
@PierreSchwang PierreSchwang marked this pull request as ready for review November 4, 2024 07:40
@PierreSchwang PierreSchwang requested a review from a team as a code owner November 4, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dordsor21 dordsor21 Awaiting requested review from dordsor21

@SirYwell SirYwell Awaiting requested review from SirYwell

Assignees
No one assigned
Labels
Feature This PR adds a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PierreSchwang @dordsor21 @SirYwell