Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add german translation #301

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add german translation #301

wants to merge 2 commits into from

Conversation

Abhinav-Bansal751
Copy link

Add German translations for the app

Purpose: This PR adds support for German addressing issue #279

Changes:

Added de.ts for German translations.
Updated translations.ts to include the new language.
Added German supportedLanguages, resources, and locales.

Testing:

Ran npm run lint and npm run fmt to check formatting and linting.

@Abhinav-Bansal751
Copy link
Author

This PR is part of my Hacktoberfest contributions!

@IraSoro IraSoro added this to the vNext milestone Oct 4, 2024
@IraSoro IraSoro linked an issue Oct 4, 2024 that may be closed by this pull request
Hacktoberfest: Add translation #279
Open
@Abhinav-Bansal751
Copy link
Author

@imblowfish @IraSoro pls review it

@imblowfish
Copy link
Collaborator

imblowfish commented Oct 6, 2024 •
edited
Loading

Hello @Abhinav-Bansal751, thank you for your contribution!
I have a question, are you german native speaker? Me and @IraSoro have some questions related to German translation which we need to discuss

@Abhinav-Bansal751
Copy link
Author

No sir, I am not native German speaker

@imblowfish
Copy link
Collaborator

It's not a problem. In this case we just need more time to check you PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imblowfish imblowfish Awaiting requested review from imblowfish

@IraSoro IraSoro Awaiting requested review from IraSoro

At least 1 approving review is required to merge this pull request.

Assignees

@Abhinav-Bansal751 Abhinav-Bansal751

Labels
hacktoberfest
Projects
peri
Status: Todo
Milestone
vNext
Development

Successfully merging this pull request may close these issues.

Hacktoberfest: Add translation
3 participants
@Abhinav-Bansal751 @imblowfish @IraSoro