ISLANDORA-1647: New XSL self-transform to strip names without nameParts

[bondjimbond]

JIRA Ticket: (https://jira.duraspace.org/browse/ISLANDORA-1647)

What does this Pull Request do?

Adds a new XSL self-transform (just a copy of the islandora_cleanup_mods_extended.xsl with more code) that strips out elements that have either no <namePart> element or an empty <namePart/>.

This allows forms to prepopulate certain elements like roleTerm silently, but remove them if they're left empty (instead of creating useless <name> elements that contain nothing but a roleTerm).

What's new?

New XSL option is available for your form associations.

How should this be tested?

• Ingest an object via a form, include details in the section but nothing in the <namePart>.
• View the resulting MODS
• Associate form with this XSLT and edit that object
• The bad <name> and its child elements should be gone
• In the same form, create some names that do have nameParts and view the MODS -- it should look normal.

Additional Notes:

I would really like to make this change simply part of the included islandora_cleanup_mods_extended.xsl file -- although I can see where folks might object. Can we perhaps discuss that here? If not, I'm happy enough to have the new option available.

Interested parties

@Islandora/7-x-1-x-committers @whikloj

[bondjimbond]

I have started using this in production and have not yet seen any ill effects.

[bondjimbond]

@whikloj Ever have a chance to review this?

[whikloj]

This works as described, but it does remove roleTerms if there is not a name associated. Because this is the destruction of user content I would not make this the default. But as a roleTerm without a name is not useful you might choose to remove it.

For instance

Test	Default transform	This transform
name exists, role term exists	Left alone	Left alone
name exists, role term doesn't	Left alone	Left alone
name doesn't exist, role term does	Left alone	Removed

[whikloj]

Starting the 24 hour 🕐

[bondjimbond]

@whikloj Can you test this with names that include <namePart type="given"> and <namePart type="family">? I'm noticing some weirdness with one of my forms (just one, not all of them) and wondering whether this transform is to blame.

Mo' testing reveals mo' problems

[whikloj]

@bondjimbond Ok, I modified the form to make two namePart fields. Added a bunch of names.

Surname	Given name	Role	Result
Whiklo	Jared	Creator	KEEP
Whiklo	Jared		KEEP
Whiklo		Creator	DELETE
	Jared	Creator	DELETE
Whiklo			DELETE
	Jared		DELETE
		Creator	DELETE

[bondjimbond]

That's what I was afraid of. I wish I could remember how I came up with those lines in the first place.