forked from jenkinsci/gerrit-trigger-plugin
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom labels setup & config #1
Open
shemuwel
wants to merge
6
commits into
master
Choose a base branch
from
custom_label
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Dec 21, 2023
-
Configuration menu - View commit details
-
Copy full SHA for abfaa28 - Browse repository at this point
Copy the full SHA abfaa28View commit details -
Extract standard "Code review" & "Verified" labels
- for reuse in global context
Configuration menu - View commit details
-
Copy full SHA for 9fe5b96 - Browse repository at this point
Copy the full SHA 9fe5b96View commit details
Commits on Feb 5, 2024
-
Move build status votes in VerdictCategory
- moved build status votes fields to VerdictCategory instead of having them as private fields in Config/GerritTrigger & mark their getters/setters deprecated - remove the entries for the removed status votes from jelly gerrit-trigger config & add them in VerdictCategory list instead (all the votes are set within VerdictCategory) - votes are now part of the VerdictCategory list (categories) so all deprecated methods are now searching through the list instead
Configuration menu - View commit details
-
Copy full SHA for 0aa5310 - Browse repository at this point
Copy the full SHA 0aa5310View commit details -
Deprecate redundant methods & make commands static
- some methods are redundant (containing 'verified' name although a simpler form already exists) - extact default gerrit commands to static fields instead
Configuration menu - View commit details
-
Copy full SHA for 446a306 - Browse repository at this point
Copy the full SHA 446a306View commit details
Commits on Feb 20, 2024
-
Add parameter expansion for custom labels
- deprecate verified/code-review minimum vote calculation methods - create string based label methods for minimum voting calcs and aggregate all categories (verified & code-review included) into the templated command allowing them to be expanded later all together - remove redundant test (in which the scenario was testing the min. voting calculation for the Verified label by using its associated method instead of testing the scenario via getBuildCompletedCommand) - update tests to check for the newly added custom label
Configuration menu - View commit details
-
Copy full SHA for 2df516e - Browse repository at this point
Copy the full SHA 2df516eView commit details -
Configuration menu - View commit details
-
Copy full SHA for f3f3d9c - Browse repository at this point
Copy the full SHA f3f3d9cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.