Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom labels setup & config #1

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add custom labels setup & config #1

wants to merge 6 commits into from

Commits on Dec 21, 2023

  1. Add workflow

    shemuwel committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    abfaa28 View commit details
    Browse the repository at this point in the history
  2. Extract standard "Code review" & "Verified" labels

    - for reuse in global context
    shemuwel committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    9fe5b96 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2024

  1. Move build status votes in VerdictCategory

    - moved build status votes fields to VerdictCategory instead of having
    them as private fields in Config/GerritTrigger & mark their
    getters/setters deprecated
    - remove the entries for the removed status votes from jelly
    gerrit-trigger config & add them in VerdictCategory list
    instead (all the votes are set within VerdictCategory)
    - votes are now part of the VerdictCategory list (categories) so all
    deprecated methods are now searching through the list instead
    shemuwel committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    0aa5310 View commit details
    Browse the repository at this point in the history
  2. Deprecate redundant methods & make commands static

    - some methods are redundant (containing 'verified' name although
    a simpler form already exists)
    - extact default gerrit commands to static fields instead
    shemuwel committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    446a306 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2024

  1. Add parameter expansion for custom labels

    - deprecate verified/code-review minimum vote calculation
    methods
    - create string based label methods for minimum voting calcs
    and aggregate all categories (verified & code-review included) into
    the templated command allowing them to be expanded later all together
    - remove redundant test (in which the scenario was testing the min.
    voting calculation for the Verified label by using its associated method
    instead of testing the scenario via getBuildCompletedCommand)
    - update tests to check for the newly added custom label
    shemuwel committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    2df516e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f3f3d9c View commit details
    Browse the repository at this point in the history