Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix opengl context leak on vid_restart #1230

Merged
merged 1 commit into from
May 1, 2024

Conversation

aufau
Copy link
Contributor

@aufau aufau commented May 1, 2024

Effect of opengl context leak varies depending on video driver. On my linux intel driver it was adding 4 new threads per vid_restart (+ heap space)

On windows + nvidia driver it didn't add new threads but each vid_restart added considerable amount of heap space to the process.

It's possible that the leak did not happen with some older SDL version, I tested with SDL2 2.28.5

@aufau aufau requested a review from a team as a code owner May 1, 2024 12:15
…her resource leaks)

SDL opengl context must be destroyed before destroying its window and
also before SDL_QuitSubSystem(SDL_INIT_VIDEO) to prevent leaks
@Daggolin Daggolin merged commit 7b9dfe7 into JACoders:master May 1, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants