Optimized ui_syscalls with null checks and cleanup #1243
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nexxus67
force-pushed
the
optimize-ui-syscalls
branch
from
3581e04
to
c593887
Compare
|
Most of these are unnecessary. And null setcolor rgba is explicitly allowed in the API so this is an invalid check. Please provide examples where these functions may be called with null input currently and is accurately not checked by the function/syscall that is used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored ui_syscalls.cpp to include null pointer checks and removed unused syscall comments for clarity. Improved code safety by validating input values, ensuring stable execution.