-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INSTALL]: Consider updating hdf5 to 1.14.3 and zlib to 1.3, or replace zlib with zlib-ng #902
Comments
Thoughts on going to zlib-ng as long as we're at it? I'd be happy to do some testing to see if it's worth the switch. |
Do you have a feeling for the potential impact of this change, i.e. how much do we believe that it is a drop-in replacement and that it will all work just fine? I am asking because I am looking at the list of planned changes for spack-stack-1.6.0, the resources we have to implement and test all of them, and the plan to roll out the release before Christmas. |
On Hercules, moving to hdf5@1.14.3 and zlib@1.3 seem to help with the netCDF/hdf5 errors related to the use of quantization in the ufs-weather-model. See the lengthy discussion in ufs-community/ufs-weather-model#2015. |
@AlexanderRichert-NOAA @ulmononian Since the testing on Hercules has shown that updating to hdf5@1.14.3 doesn't solve the issue with the parallel writes, I suggest to not try to squeeze this into spack-stack-1.6.0. Instead, make the update in 1.7.0 and use the extra time we have until the spack-stack-1.7.0 release to move to |
zlib-ng for 1.6.0 or 1.7.0? FYI I'll be off for a while starting next Wednesday, so if you want hold off for 1.7.0 that's fine with me (though maybe we have a bunch of testing to do either way...). |
@climbfuji @AlexanderRichert-NOAA is the move to zlib-ng without risk this close to 1.6.0? is it necessary? |
Sorry for the confusion. I clarified the language above: "use the extra time we have until the spack-stack-1.7.0 release to move to zlib-ng" |
ah, i misread! yes i think we should hold off on this until 1.7.0. |
|
Did anyone ever test changing zlib->zlib-ng? I can't remember if I did at one point. In any case I'd be happy to test that on its own, then if it does changes thing numerically, we can have UFSWM folks reevaluate RT results along with other changes. |
I ran a couple UFS WM RTs just now with a stack built on the latest version of zlib-ng and they both completed successfully and with results matching baselines. So I vote for moving forward with zlib-ng; I'm happy to make the necessary changes. |
Update to hdf5 was done, waiting for switch to |
Sorry I took so long to respond but we did indeed test zlib-ng and it worked and was about 10% faster. So we should be using it. |
Thanks, that's good to know. I'll test with JEDI this week and hopefully EPIC can run some tests on their end, too. |
@RatkoVasic-NOAA have you had a chance to run tests with this (zlib-ng) with the wm or srw? |
@ulmononian , no, both are using zlib/1.2.13 |
I tested a slew of UFS WM RTs on Hera using zlib-ng, but if you want to set up more tests, you can add a checklist in #1016 to complete before we merge. |
Closing this as done. We've updated to |
Package name
hdf5 / zlib
Package version/tag
1.14.3 / 1.3
Build options
current
Installation timeframe
Consider adding to spack-stack-1.6.0 if time permits
Other information
n/a
WCOSS2
WCOSS2: General questions
already approved on wcoss2 (hdf5@1.14.0, zlib@1.3)
WCOSS2: Installation and testing
No response
WCOSS2: Technical & security review list
WCOSS2: Additional comments
No response
The text was updated successfully, but these errors were encountered: