Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from zlib to zlib-ng #1016

Merged
merged 4 commits into from
Mar 5, 2024
Merged

Conversation

AlexanderRichert-NOAA
Copy link
Collaborator

@AlexanderRichert-NOAA AlexanderRichert-NOAA commented Mar 1, 2024

Summary

This PR moves from zlib to zlib-ng. Time to get with the times.

For now I'm not touching any of the templates.

Testing

Tested on Hera & personal machine. Successfully concretizes without zlib, and on Hera, the UFS WM deps build and RTs run successfully.

Applications affected

All

Systems affected

All

Dependencies

JCSDA/spack#409

Issue(s) addressed

#902

Checklist

  • This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.

@climbfuji climbfuji added INFRA JEDI Infrastructure NOAA-EMC labels Mar 1, 2024
@AlexanderRichert-NOAA
Copy link
Collaborator Author

AlexanderRichert-NOAA commented Mar 1, 2024

@edwardhartnett
Copy link
Collaborator

I actually thought we were already doing this.

In our testing ng-zlib was about 10% faster than zlib.

.gitmodules Outdated Show resolved Hide resolved
@climbfuji
Copy link
Collaborator

@AlexanderRichert-NOAA I finally started testing this PR together with #972 and JCSDA/spack#400

Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this with a few JEDI-Skylab experiments and it works just fine. Thanks!

@climbfuji climbfuji merged commit ed48610 into JCSDA:develop Mar 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INFRA JEDI Infrastructure NOAA-EMC
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

4 participants