Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gsibec@1.2.1, add Discover-Milan Intel MPI tuning flags #1027

Merged
merged 6 commits into from
Mar 12, 2024
Merged

Add gsibec@1.2.1, add Discover-Milan Intel MPI tuning flags #1027

merged 6 commits into from
Mar 12, 2024

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Mar 11, 2024 •
edited
Loading

Summary

This PR updates the submodule pointer for spack and the config files to bump gsibec to version 1.2.1.

Also: Add Intel MPI tuning flags for Discover Milan (from @mathomp4 and tested by @Dooruk and @climbfuji).

Testing

Applications affected

JEDI

Systems affected

None

Dependencies

Issue(s) addressed

Resolves #1021

Checklist

  • This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.

@climbfuji climbfuji self-assigned this Mar 11, 2024
@climbfuji climbfuji added the INFRA JEDI Infrastructure label Mar 11, 2024
@climbfuji climbfuji assigned climbfuji and unassigned climbfuji Mar 11, 2024
@climbfuji climbfuji mentioned this pull request Mar 11, 2024
Merged
3 tasks
@climbfuji climbfuji marked this pull request as ready for review March 11, 2024 14:02
@climbfuji
Copy link
Collaborator Author

@Dooruk See commit 8f364d7 for the Discover Milan env variables for Intel

@climbfuji climbfuji mentioned this pull request Mar 11, 2024
Closed
@Dooruk
Copy link
Collaborator

Dooruk commented Mar 11, 2024 •
edited
Loading

@Dooruk See commit 8f364d7 for the Discover Milan env variables for Intel

Thanks @climbfuji

@climbfuji climbfuji changed the title Add gsibec@1.2.1 Add gsibec@1.2.1, add Discover-Milan Intel MPI tuning flags Mar 11, 2024
@climbfuji climbfuji requested a review from mathomp4 March 12, 2024 02:10
shlyaeva
shlyaeva approved these changes Mar 12, 2024
View reviewed changes
Copy link
Collaborator

@shlyaeva shlyaeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating gsibec! (did not review other changes)

@climbfuji climbfuji merged commit 10744de into JCSDA:develop Mar 12, 2024
7 checks passed
@climbfuji climbfuji deleted the feature/gsibec_121 branch March 12, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RatkoVasic-NOAA RatkoVasic-NOAA RatkoVasic-NOAA approved these changes

@shlyaeva shlyaeva shlyaeva approved these changes

@AlexanderRichert-NOAA AlexanderRichert-NOAA Awaiting requested review from AlexanderRichert-NOAA

@mathomp4 mathomp4 Awaiting requested review from mathomp4

Assignees

@climbfuji climbfuji

Labels
INFRA JEDI Infrastructure
Projects
No open projects
spack-stack-1.7.0 (2024 Q1)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[INSTALL]: gsibec@1.2.1 for spack-stack-1.7.0
5 participants
@climbfuji @Dooruk @mathomp4 @shlyaeva @RatkoVasic-NOAA