Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding py-ruamel modules for gmao-swell-env #1311

Merged
merged 3 commits into from
Sep 26, 2024

Conversation

ashley314
Copy link
Collaborator

@ashley314 ashley314 commented Sep 25, 2024

Summary

This PR adds py-ruamel-yaml and py-ruamel-yaml-clib to the gmao-swell-env.

Testing

Describe the testing done for this PR.

Applications affected

List all known applications (UFS WM, JEDI, SRW, etc.) intentionally or unintentionally affected by this PR.

Systems affected

List all systems intentionally or unintentionally affected by this PR.

Dependencies

None

Issue(s) addressed

Resolves #1253

Checklist

  • This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.

@ashley314 ashley314 added the INFRA JEDI Infrastructure label Sep 25, 2024
@ashley314 ashley314 self-assigned this Sep 25, 2024
Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, all CI tests fail because of duplicate packages being built:

===
kac2og5  py-ruamel-yaml@0.17.32%oneapi@2024.2.0  build_system=python_pip  arch=linux-ubuntu22.04-zen2
xi6qwz3  py-ruamel-yaml@0.17.16%oneapi@2024.2.0  build_system=python_pip  arch=linux-ubuntu22.04-zen2
Duplicates found!
Error: Process completed with exit code 1.

@ashley314 ashley314 marked this pull request as ready for review September 26, 2024 20:50
@ashley314
Copy link
Collaborator Author

Thanks @climbfuji for pointing that out. I pinned py-ruamel-yaml to the 0.17.16 version after checking with what gets loaded with spack-stack 1.8.0 on discover

@ashley314
Copy link
Collaborator Author

@srherbener github is not letting me add more reviewers right now, but when you get the chance can you take a look at these changes too? Thanks!

Copy link
Collaborator

@Dooruk Dooruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for the quick turnaround!

@climbfuji climbfuji merged commit 95c30b2 into JCSDA:develop Sep 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INFRA JEDI Infrastructure
Projects
Development

Successfully merging this pull request may close these issues.

ruamel for gmao-swell-env?
3 participants