-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI tests on R&D ParallelCluster #940
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the code looks good. It seems to be capturing what should have been run before this update. I guess we will see with the testing. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it runs and works then this is fine. Would it make sense to use strategy:matrix:...
to avoid all the indentation, and also allow gcc and intel to run in parallel? I have no problem with the current approach though.
That's a good idea. I'll make this change in a follow-up PR. That will also provide a chance to fix issues that we can only find out by merging this PR. |
Summary
This is more of a workaround than a good solution. By looping over the two compilers, reconcretizing and installing, I can get around the concretizer problems that are described in #939.
I tested this manually on AWS ParallelCluster. Since it runs via
workflow_dispatch
, I can't run the CI tests from my fork/branch. We'll have to merge and check afterwards if it works.Testing
See above
Applications affected
None
Systems affected
AWS ParallelCluster CI runs only
Dependencies
none
Issue(s) addressed
Resolves #939
Checklist