Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI tests on R&D ParallelCluster #940

Merged
merged 5 commits into from
Jan 16, 2024

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Jan 10, 2024

Summary

This is more of a workaround than a good solution. By looping over the two compilers, reconcretizing and installing, I can get around the concretizer problems that are described in #939.

I tested this manually on AWS ParallelCluster. Since it runs via workflow_dispatch, I can't run the CI tests from my fork/branch. We'll have to merge and check afterwards if it works.

Testing

See above

Applications affected

None

Systems affected

AWS ParallelCluster CI runs only

Dependencies

none

Issue(s) addressed

Resolves #939

Checklist

  • This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.

@climbfuji climbfuji changed the title WIP Fix CI tests on R&D ParallelCluster, pull in backports ... Fix CI tests on R&D ParallelCluster, pull in backports/v0.21.1 from spack develop Jan 14, 2024
@climbfuji climbfuji marked this pull request as ready for review January 14, 2024 02:44
@climbfuji climbfuji self-assigned this Jan 14, 2024
@climbfuji climbfuji added the INFRA JEDI Infrastructure label Jan 14, 2024
@climbfuji climbfuji changed the title Fix CI tests on R&D ParallelCluster, pull in backports/v0.21.1 from spack develop Fix CI tests on R&D ParallelCluster Jan 16, 2024
Copy link
Collaborator

@srherbener srherbener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the code looks good. It seems to be capturing what should have been run before this update. I guess we will see with the testing. Thanks!

Copy link
Collaborator

@AlexanderRichert-NOAA AlexanderRichert-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it runs and works then this is fine. Would it make sense to use strategy:matrix:... to avoid all the indentation, and also allow gcc and intel to run in parallel? I have no problem with the current approach though.

@climbfuji
Copy link
Collaborator Author

If it runs and works then this is fine. Would it make sense to use strategy:matrix:... to avoid all the indentation, and also allow gcc and intel to run in parallel? I have no problem with the current approach though.

That's a good idea. I'll make this change in a follow-up PR. That will also provide a chance to fix issues that we can only find out by merging this PR.

@climbfuji climbfuji merged commit c2b3afd into JCSDA:develop Jan 16, 2024
7 checks passed
@climbfuji climbfuji deleted the feature/fix_ci_rnd branch January 16, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INFRA JEDI Infrastructure
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Nightly builds on JCSDA R&D AWS ParallelCluster with Intel broken
3 participants