add clientOrderId to GateIoRestClientSpotApiTrading.EditOrderAsync()

JKorf · Oct 2, 2024 · fcd2e4a · fcd2e4a
1 parent 3248f6e
commit fcd2e4a
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/GateIo.Net.UnitTests/RestRequestTests.cs b/GateIo.Net.UnitTests/RestRequestTests.cs
@@ -118,7 +118,7 @@ public async Task ValidateSpotTradingCalls()
             await tester.ValidateAsync(client => client.SpotApi.Trading.GetOrderAsync("ETH_USDT", 123), "GetOrder", ignoreProperties: new List<string> { "create_time", "update_time", "fill_price" });
             await tester.ValidateAsync(client => client.SpotApi.Trading.CancelAllOrdersAsync("ETH_USDT"), "CancelAllOders", ignoreProperties: new List<string> { "create_time", "update_time", "fill_price" });
             await tester.ValidateAsync(client => client.SpotApi.Trading.CancelOrdersAsync(new[] { new GateIoBatchCancelRequest { Id = "123", Symbol = "ETH_USDT" } }), "CancelOrders");
-            await tester.ValidateAsync(client => client.SpotApi.Trading.EditOrderAsync("ETH_USDT", 123, 123), "EditOrder", ignoreProperties: new List<string> { "create_time", "update_time", "fill_price" });
+            await tester.ValidateAsync(client => client.SpotApi.Trading.EditOrderAsync("ETH_USDT", 123, price: 123), "EditOrder", ignoreProperties: new List<string> { "create_time", "update_time", "fill_price" });
             await tester.ValidateAsync(client => client.SpotApi.Trading.CancelOrderAsync("ETH_USDT", 123), "CancelOrder", ignoreProperties: new List<string> { "create_time", "update_time", "fill_price" });
             await tester.ValidateAsync(client => client.SpotApi.Trading.GetUserTradesAsync(), "GetUserTrades", ignoreProperties: new List<string> { "create_time" });
             await tester.ValidateAsync(client => client.SpotApi.Trading.CancelOrdersAfterAsync(TimeSpan.Zero), "CancelOrdersAfter");

diff --git a/GateIo.Net/Clients/SpotApi/GateIoRestClientSpotApiTrading.cs b/GateIo.Net/Clients/SpotApi/GateIoRestClientSpotApiTrading.cs
@@ -223,13 +223,16 @@ public async Task<WebCallResult<IEnumerable<GateIoCancelResult>>> CancelOrdersAs
         /// <inheritdoc />
         public async Task<WebCallResult<GateIoOrder>> EditOrderAsync(
             string symbol,
-            long orderId,
+            long? orderId = null,
+            string? clientOrderId = null,
             decimal? price = null,
             decimal? quantity = null,
             string? amendText = null,
             SpotAccountType? accountType = null,
             CancellationToken ct = default)
         {
+            var id = orderId?.ToString() ?? clientOrderId;
+
             var queryParameters = new ParameterCollection();
             queryParameters.Add("currency_pair", symbol);
 
@@ -238,7 +241,7 @@ public async Task<WebCallResult<GateIoOrder>> EditOrderAsync(
             bodyParameters.AddOptionalString("amount", quantity);
             bodyParameters.AddOptional("amend_text", amendText);
             bodyParameters.AddOptionalEnum("account", accountType);
-            var request = _definitions.GetOrCreate(new HttpMethod("Patch"), "/api/v4/spot/orders/" + orderId, GateIoExchange.RateLimiter.RestSpotOrderPlacement, 1, true);
+            var request = _definitions.GetOrCreate(new HttpMethod("Patch"), "/api/v4/spot/orders/" + id, GateIoExchange.RateLimiter.RestSpotOrderPlacement, 1, true);
             return await _baseClient.SendAsync<GateIoOrder>(request, queryParameters, bodyParameters, ct).ConfigureAwait(false);
         }
 

diff --git a/GateIo.Net/Interfaces/Clients/SpotApi/IGateIoRestClientSpotApiTrading.cs b/GateIo.Net/Interfaces/Clients/SpotApi/IGateIoRestClientSpotApiTrading.cs
@@ -134,7 +134,8 @@ Task<WebCallResult<IEnumerable<GateIoCancelResult>>> CancelOrdersAsync(
         /// <para><a href="https://www.gate.io/docs/developers/apiv4/#amend-an-order" /></para>
         /// </summary>
         /// <param name="symbol">Symbol, for example `ETH_USDT`</param>
-        /// <param name="orderId">Order id</param>
+        /// <param name="orderId">Order id, either orderId or clientOrderId required</param>
+        /// <param name="clientOrderId">user custom ID(i.e., t-123c456f), either `orderId` or `clientOrderId` required</param>
         /// <param name="price">New price</param>
         /// <param name="quantity">New quantity</param>
         /// <param name="amendText">Custom info during amending order</param>
@@ -143,7 +144,8 @@ Task<WebCallResult<IEnumerable<GateIoCancelResult>>> CancelOrdersAsync(
         /// <returns></returns>
         Task<WebCallResult<GateIoOrder>> EditOrderAsync(
             string symbol,
-            long orderId,
+            long? orderId,
+            string? clientOrderId = null,
             decimal? price = null,
             decimal? quantity = null,
             string? amendText = null,