[iOS10] UILocalNotification is deprecated from iOS10 and up #19
Conversation
There was a problem hiding this comment.
Sorry for taking so long! I missed this originally.
I'm a bit confused by the duplicate #if/#elif lines: what's the logic there?
Alternatively I'm also thinking: this could use some clean up, and use NS_AVAILABLE declarations and @available instead.
| @@ -107,7 +108,8 @@ NS_ASSUME_NONNULL_BEGIN | |||
| - (void)application:(UIApplication *)application didReceiveRemoteNotification:(NSDictionary *)userInfo fetchCompletionHandler:(void (^)(UIBackgroundFetchResult result))completionHandler; | |||
| #endif | |||
|
|
|||
| #if JSIOS8SDK | |||
| #if JSIOS10SDK | |||
| #elif JSIOS8SDK | |||
There was a problem hiding this comment.
@JaviSoto So didRegisterUserNotifications and handleActionWithIdentifier were both added in iOS8 but deprecated in iOS10.
and #if JSIOS8SDK condition is true for all iOS versions 8 and above. Hence I added an if for iOS10> where those methods are not registered
There was a problem hiding this comment.
Ah, should this be #if JSIOS8SDK && ! JSIOS10SDK perhaps to make it more clear?
I think the JSIOXSDK macros should be renamed to like JSSDKAtLeastIOS9. That way this would be a bit clearer.
Alternatively, what I would like is to stop using those macros, and instead, add:
NS_DEPRECATED_IOS(8_0, 10_0)What do you think?
|
I am not sure if you can provide a min and max iOS version for NS_AVAILABLE_IOS. Though I have renamed the macros to something that's way more readable. Let me know how that looks. |
Yeah, look at NS_DEPRECATED_IOS(INTRODUCED, DEPRECATED)
// E.g.:
NS_DEPRECATED_IOS(2_0, 10_0) |
Upgraded our project to minimum iOS10. Fixed all the warnings