Decorated dialog support #513
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devkanro
added
feature
rock3r
reviewed
Aug 5, 2024
Comment on lines
+49
to
+54
| if (!JBR.isAvailable()) { | ||
| error( | ||
| "DecoratedWindow can only be used on JetBrainsRuntime(JBR) platform, " + | ||
| "please check the document https://github.com/JetBrains/jewel#int-ui-standalone-theme", | ||
| ) | ||
| } |
There was a problem hiding this comment.
Worth extracting into assertUsingJBR() and reuse in DecoratedWindow, too?
| } | ||
|
|
||
| // Using undecorated window for linux | ||
| val undecorated = DesktopPlatform.Linux == DesktopPlatform.Current |
There was a problem hiding this comment.
Nit:
Suggested change
| val undecorated = DesktopPlatform.Linux == DesktopPlatform.Current | |
| val undecorated = DesktopPlatform.Current == DesktopPlatform.Linux |
Comment on lines
+13
to
+14
| import androidx.compose.runtime.getValue | ||
| import androidx.compose.runtime.setValue |
There was a problem hiding this comment.
Doesn't look like these are used
| @@ -1,6 +1,6 @@ | |||
| [versions] | |||
| commonmark = "0.22.0" | |||
| composeDesktop = "1.7.0-dev1743" | |||
| composeDesktop = "1.7.0-dev1750" | |||
There was a problem hiding this comment.
Was this needed? Otherwise I'd do it separatey so it shows in the release notes
|
@devkanro ping |
|
@devkanro ping again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR provide DecoratedDialog support and upgrade the JBR api to 1.0.2
fixed #512