Reimplement/fix/complete implementation of scrollbars #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rock3r
added
feature
rock3r
force-pushed
the
scrollbar-behaviour
branch
2 times, most recently
from
44ced54
to
cc5cfe4
Compare
rock3r
force-pushed
the
scrollbar-behaviour
branch
from
bd764ca
to
a601251
Compare
* Implement TrackClickBehaviors correctly * Fix macOS scrollbar styling * Provide ScrollableContainers for a simple, turn-key scrollbar API * Make expanded scrollbar not hide while the mouse moves over the scrollable composable * Fix the expanding behaviour and animation on macOS * Fix the visibility logic on macOS * Resolve a number of inconsistencies with Swing implementations * Simplify and consolidate internal implementation * Separate tabStrip scrollbar styling
* Fix thumb colour fade in AlwaysVisible mode * Move sample border to Outside so it doesn't overlap the scrollbar
* Rework layout/draw logic to finally align with Swing, in dark mode too * Switch to custom drawing for the thumb for more control
* Cleanup code * Update API definitions
* Make bridge compile * Fix styling in bridge * Update bridge samples * Fix TextArea scrollbars
* Fix bug in ScrollableContainer * Improve ReleasesSampleCompose
* Rewrite MacScrollbarHelper to avoid native crashes
* Add decorationModifier to TextArea API (useful e.g., for padding when there are scrollbars) * Fix ScrollableContainerImpl layout logic and bugs * Fix one HorizontallyScrollableContainer using vScroll by mistake * Use HorizontallyScrollableContainer in Markdown block renderer * Update standalone sample Markdown with new APIs
* Add mouse move linger behaviour to all ScrollableContainers * Add horizontal scrolling example to standalone sample * Fix ScrollableContainerImpl layout bug with WhenScrolling
* Remove debug bg from Scrollbars sample * Fix thumb appearing/disappearing animation * Fix colour animations * Keep AlwaysVisible thumb "hovered" while dragging * Fix styling in the bridge
* Fix InputField ignoring provided scrollbar style * Remove useless KDocs from TextArea/TextField * Clean up code * Mark non-state-based TextArea/TextField as scheduled for removal
* Fix native crash when TextField/TextArea don't have a fixed width * Redo the entire BTF2-based InputField implementation, better * Expose all the new parameters that BTF2-based InputField has to the users of TextField and TextArea * Fix TextArea decoration and scrollbars
* Fix scrollbars on Windows and Linux * Fix TextArea end padding to account for scrollbar
rock3r
force-pushed
the
scrollbar-behaviour
branch
from
7c708d5
to
31d1b98
Compare
* Clean up code * Add scrollbar to undecorated TextAreas
|
@hamen @devkanro I am sorry this ended up being huge, I had to rewrite ~95% of everything scrollbars as the previous implementation was simply not working well, and/or not flexible enough. Once this is merged we can ship 0.23.0, finally! PS: there are some minor inconsistencies with Swing tracked in the linked issues in the description — they're all P2/P3 for what I am concerned, though. |
|
No worries. We will take care of it on Monday 🙏🏻 |
hamen
approved these changes
Aug 26, 2024
ide-laf-bridge/src/main/kotlin/org/jetbrains/jewel/bridge/ScrollbarHelper.kt
Show resolved
Hide resolved
ide-laf-bridge/src/main/kotlin/org/jetbrains/jewel/bridge/ScrollbarHelper.kt
Show resolved
Hide resolved
ide-laf-bridge/src/main/kotlin/org/jetbrains/jewel/bridge/SwingBridgeService.kt
Show resolved
Hide resolved
ide-laf-bridge/src/main/kotlin/org/jetbrains/jewel/bridge/theme/IntUiBridge.kt
Show resolved
Hide resolved
ui/src/main/kotlin/org/jetbrains/jewel/ui/component/ScrollableContainer.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR overhauls how scrollbars are implemented, fixing all known issues and implementing the features that were forgotten/missing.
AlwaysVisible, where the scrollbars are always visible and have always the same thickness. This is the most similar to Win/Linux behavior on macOS but doesn't 100% match it.WhenScrolling, scrollbars are only visible while scrollingNextPage, clicking moves the viewport by a whole page, but not moreJumpToSpot, moves the viewport to the point that was clicked (may be more than a page)WhenScrolling+JumpToPoint, Win/Linux:AlwaysVisible+JumpToPoint)ScrollbarHelperto react to macOS system prefs changes, like Swing does. On Win/Linux it's always using the defaults, like in standalone.ScrollableContainerAPI makes it all super easy for you, and handles overlaying or not the scroll bars over the scrollable content, like Swing doesscrollbarContentSafePaddingfunction provides an optional padding to apply to scrollable content important parts to avoid them being overlapped byWhenScrollingscrollbars.TODO
ScrollableContainervariants