Fix parsing of POM files without namespaces #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XmlUtil is strict when matching namespaces, but some very old pom.xml files do not provide any namespace. This commit introduces a wrapper around `XmlReader` to handle POM files without namespaces. Now `XML.decodePomFromString(String)` should be used instead of `XML.decodeFromString<ProjectObjectModel>(String)`. More information: pdvrieze/xmlutil#170
pdvrieze
reviewed
Jul 27, 2023
Comment on lines
+84
to
+86
| val namespaceAgnosticReader = object : XmlReader by XmlStreaming.newReader(string) { | ||
| override val namespaceURI: String get() = POM_XML_NAMESPACE | ||
| } |
There was a problem hiding this comment.
Please note that this breaks unqualified attributes (as used by default).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XmlUtil is strict when matching namespaces, but some very old pom.xml files do not provide any namespace.
This commit introduces a wrapper around
XmlReaderto handle POM files without namespaces. NowXML.decodePomFromString(String)should be used instead ofXML.decodeFromString<ProjectObjectModel>(String).More information: pdvrieze/xmlutil#170