-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Handle uninstalled Staged Expenditure extension #3402
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nicely done Jakub! All the test cases work as expected.
I'm not sure whether these pills should change to the "Uninstalled" pill for extensions which have been uninstalled - I think this is how the reputation extension behaves as far as I remember. But this can be it's own PR.
Tested making another staged payment on the new extension installation and all worked without issue. Great job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job on this one @jakubcolony 👏 💯
Created the 4 staged payments and advanced them to a different step
The errors are still showing up for the previous staged payments
And for regression I created a new staged payment and managed to finalise it
Awesome job 🥇
Just one question that I have @jakubcolony is if we don't want to actually show up the card in the Grouped actions list?
Without applying this diff, I didn't manage to see it yet there
diff --git a/src/components/v5/common/ActionSidebar/partials/PaymentGroup/GroupList.ts b/src/components/v5/common/ActionSidebar/partials/PaymentGroup/GroupList.ts
index e2c060dff..fcd52f47d 100644
--- a/src/components/v5/common/ActionSidebar/partials/PaymentGroup/GroupList.ts
+++ b/src/components/v5/common/ActionSidebar/partials/PaymentGroup/GroupList.ts
@@ -1,11 +1,11 @@
import {
HandCoins,
Money,
+ Steps,
// @TODO: uncomment when streaming payment,split payment and staged payment will be ready
// Waves,
// ArrowsOutLineHorizontal,
- // Steps,
} from '@phosphor-icons/react';
import { Action } from '~constants/actions.ts';
@@ -43,13 +43,13 @@ export const GROUP_LIST = [
// Icon: ArrowsOutLineHorizontal,
// action: Action.SplitPayment,
// },
- // {
- // title: formatText({ id: 'actions.stagedPayment' }),
- // description: formatText({
- // id: 'actions.description.stagedPayment',
- // }),
- // Icon: Steps,
- // action: Action.StagedPayment,
- // isNew: true,
- // },
+ {
+ title: formatText({ id: 'actions.stagedPayment' }),
+ description: formatText({
+ id: 'actions.description.stagedPayment',
+ }),
+ Icon: Steps,
+ action: Action.StagedPayment,
+ isNew: true,
+ },
];
|
Description
This PR fixes an issue where users could interact with staged payments created using a different installation of the Staged Expenditure extension. In order for the checks to work properly, there is a block-ingestor PR that facilitates storing the relevant extension address on the expenditure object.
In addition, it fixes an issue with the flow where you could not see previous funding actions after you uninstalled the extension. That meant if there was an unclaimed motion, there was no way for you to claim it.
Testing
Uninstall Staged Expenditure extension.
Verify that the uninstalled extension warning is shown in each payment you created. You should also be able to go back to any of the previous steps and see the details of the action related to that step (ie. the creator, date, etc.).
Now install Staged Expenditure extension again.
Verify the warning is still shown for payments created using the uninstalled extension.
Create another Staged Expenditure payment and move it through all stages to check for regressions.
Resolves #3304