Merge pull request opendatahub-io#63 from heyselbi/iss-58-quickstart

addressing comments from PR 61

demo/kserve/custom-manifests/minio/minio-secret.yaml

@@ -8,5 +8,5 @@ metadata:
     serving.kserve.io/s3-useanoncredential: "false" # omitting this is the same as false, if true will ignore provided credential and use anonymous credentials
   name: storage-config
 stringData:
-  "AWS_ACCESS_KEY_ID": "<accesskey>"
-  "AWS_SECRET_ACCESS_KEY": "<secretkey>"
+  "AWS_ACCESS_KEY_ID": "admin"
+  "AWS_SECRET_ACCESS_KEY": "password"

demo/kserve/custom-manifests/minio/minio.yaml

@@ -24,9 +24,9 @@ spec:
         - /data1
       env:
         - name: MINIO_ACCESS_KEY
-          value:  <accesskey>
+          value:  admin
         - name: MINIO_SECRET_KEY
-          value: <secretkey>
+          value: password
       image: quay.io/opendatahub/modelmesh-minio-examples:caikit-flan-t5
       imagePullPolicy: Always
       name: minio

demo/kserve/deploy-remove.md

@@ -10,14 +10,13 @@ Before proceeding, please make sure you are in the `/caikit-tgis-serving/demo/ks
 If you have your model in another S3-like object storage (e.g., AWS S3), you can skip this step.
 We will create a new project/namespace for minio and deploy it together with service account and data connection (secret with generated access key ID and secret access key). 
 ~~~
-ACCESS_KEY_ID=THEACCESSKEY
-SECRET_ACCESS_KEY=$(openssl rand -hex 32)
+ACCESS_KEY_ID=admin
+SECRET_ACCESS_KEY=password
 MINIO_NS=minio
 
 oc new-project ${MINIO_NS}
-sed "s/<accesskey>/$ACCESS_KEY_ID/g"  ./custom-manifests/minio/minio.yaml | sed "s+<secretkey>+$SECRET_ACCESS_KEY+g" | tee ./minio-current.yaml | oc -n ${MINIO_NS} apply -f -
-sed "s/<accesskey>/$ACCESS_KEY_ID/g" ./custom-manifests/minio/minio-secret.yaml | sed "s+<secretkey>+$SECRET_ACCESS_KEY+g" |sed "s/<minio_ns>/$MINIO_NS/g" | tee ./minio-secret-current.yaml | oc -n ${MINIO_NS} apply -f - 
-
+oc apply -f minio/minio.yaml -n ${MINIO_NS}
+sed s/<minio_ns>/$MINIO_NS/g" ./custom-manifests/minio/minio-secret.yaml | tee ./minio-secret-current.yaml | oc -n ${MINIO_NS} apply -f - 
 sed "s/<minio_ns>/$MINIO_NS/g" ./custom-manifests/minio/serviceaccount-minio.yaml | tee ./serviceaccount-minio-current.yaml | oc -n ${MINIO_NS} apply -f - 
 ~~~
 Instructions above deploy an already containerized LLM model. To containerize your own LLM model into a minio bucket for testing, follow instructions [here](/demo/kserve/create-minio.md).

demo/kserve/install-manual.md

@@ -44,8 +44,7 @@ oc -n istio-system apply -f custom-manifests/service-mesh/smmr-${TARGET_OPERATOR
 oc apply -f custom-manifests/service-mesh/peer-authentication.yaml
 oc apply -f custom-manifests/service-mesh/peer-authentication-${TARGET_OPERATOR_TYPE}.yaml 
 ~~~
-This is needed because of [this](https://access.redhat.com/documentation/en-us/openshift_container_platform/4.12/html/serverless/serving#serverless-domain-mapping-custom-tls-cert_domain-mapping-custom-tls-cert).
-
+We use PeerAuthentications to enable mTLS according to [Openshift Serverless Documentation](https://access.redhat.com/documentation/en-us/red_hat_openshift_serverless/1.28/html/serving/configuring-custom-domains-for-knative-services#serverless-domain-mapping-custom-tls-cert_domain-mapping-custom-tls-cert)
 ~~~
 oc apply -f custom-manifests/serverless/operators.yaml
 sleep 30

docs/README.md

@@ -36,7 +36,7 @@ There are three ways to install the KServe/Caikit/TGIS stack (includes the insta
 2. [Manual installation](/demo/kserve/install-manual.md)
 
 ## Demos with LLM model
-- [Deploy a model and remove/undeploy a model](/docs/deploy-remove.md)
+- [Deploy a model and remove/undeploy a model](/demo/kserve/deploy-remove.md)
 - [Split traffic](/demo/kserve/traffic-splitting.md)
 - [Upgrade runtime](/demo/kserve/upgrade-runtime.md)
 - [Access metrics](/demo/kserve/metrics.md)