Speeding up strain rate and deviatoric stress kernels #110
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Powers with floating point exponents are quite slow, and this is where mos of the time is spent when computing the stress rate or deviatoric stress of creep laws. However, in many cases the exponentials in these equations are just
x^0
,x^1
or1^n
, where there is not really a need to compute the power. Addresses #109This PR adds a check to see whether any of these cases occurs, by introducing:
in all the
compute_εII
andcompute_τII
methods.This has a non-significant speed up when e.g. computing the viscosity:
This branch:
#main
branch:This could be potentially improved by moving some of these checks to compile time, but this means wraping the exponentials in the creep laws objects in
Val
s: