Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move testing to GenericGraph #224

Open
12 tasks done
gdalle opened this issue Feb 9, 2023 · 3 comments
Open
12 tasks done

Move testing to GenericGraph #224

gdalle opened this issue Feb 9, 2023 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@gdalle
Copy link
Member

gdalle commented Feb 9, 2023

We recently introduced two types called GenericGraph and GenericDiGraph that wrap a SimpleGraph or a SimpleDiGraph. These generic types try to fulfill the AbstractGraph interface in a minimal way, while having no other methods implemented. The idea is then to test functions that can take an AbstractGraph with these generic types instead of simple graphs, in order to verify that they would indeed work with any AbstractGraph.
Similar things can be found in the Julia standard library, for example Test.GenericArray and Test.GenericString.

Now we need to change our tests, so that they use the generic graph types, and try to spot and fix bugs that occur during that process. It is probably not possible to do this for all functions, but at least we can spot the places where that is the case.

Some progress has already been done or at least started in:

@simonschoelly
Copy link
Contributor

simonschoelly commented Jun 29, 2023

I don't think this should be tagged as a v2.0 issue, there is no reason not to use GenericGraph right now.

@gdalle gdalle modified the milestones: v2.0, v1.9 Jun 29, 2023
@gdalle
Copy link
Member Author

gdalle commented Jun 29, 2023

Fair enough

@gdalle
Copy link
Member Author

gdalle commented Sep 14, 2023

@simonschoelly is there any more we can do on this end? I would keep the issue open though

@gdalle gdalle removed this from the v1.9 milestone Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
No open projects
Status: In Progress
Development

No branches or pull requests

2 participants