-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move testing to GenericGraph
#224
Labels
Comments
I don't think this should be tagged as a v2.0 issue, there is no reason not to use |
Fair enough |
This was referenced Jul 2, 2023
@simonschoelly is there any more we can do on this end? I would keep the issue open though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We recently introduced two types called
GenericGraph
andGenericDiGraph
that wrap aSimpleGraph
or aSimpleDiGraph
. These generic types try to fulfill theAbstractGraph
interface in a minimal way, while having no other methods implemented. The idea is then to test functions that can take anAbstractGraph
with these generic types instead of simple graphs, in order to verify that they would indeed work with anyAbstractGraph
.Similar things can be found in the Julia standard library, for example
Test.GenericArray
andTest.GenericString
.Now we need to change our tests, so that they use the generic graph types, and try to spot and fix bugs that occur during that process. It is probably not possible to do this for all functions, but at least we can spot the places where that is the case.
Some progress has already been done or at least started in:
test/biconnectivity
Use GenericGraph for testing biconnectivity algorithms #270test/centrality
Test centrality with generic graph #272test/community
Test community with generic graph #273test/cycles
Test cycles with generic graph #274test/shortestpaths
Use GenericGraph for testing shortestpaths algorithms #275test/spanningtrees
Use GenericGraph for testing spanningtrees algorithms #276test/connectivity.jl
Tests for various files with generic graph #278test/core.jl
Tests for various files with generic graph #278test/degeneracy.jl
Tests for various files with generic graph #278test/distance.jl
Tests for various files with generic graph #278test/edit_distance.jl
Tests for various files with generic graph #278test/operators.jl
Tests for various files with generic graph #278The text was updated successfully, but these errors were encountered: