Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test community with generic graph #273

Merged

Conversation

simonschoelly
Copy link
Contributor

@simonschoelly simonschoelly commented Jul 2, 2023

This PR makes the tests for the community algorithm use GenericGraph

There were only some small changes necessary to src/community/clustering.jl to make the tests work.

@simonschoelly simonschoelly self-assigned this Jul 2, 2023
@simonschoelly simonschoelly force-pushed the test-community-with-generic-graph branch from 89811a0 to 8895977 Compare July 2, 2023 18:47
@codecov
Copy link

codecov bot commented Jul 2, 2023

Codecov Report

Merging #273 (6c858eb) into master (d3b2706) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #273   +/-   ##
=======================================
  Coverage   97.29%   97.29%           
=======================================
  Files         114      114           
  Lines        6659     6659           
=======================================
  Hits         6479     6479           
  Misses        180      180           

@simonschoelly simonschoelly added the do not merge Do not merge this PR (yet) label Jul 2, 2023
@gdalle
Copy link
Member

gdalle commented Jul 2, 2023

Partial solution to #224

@simonschoelly simonschoelly force-pushed the test-community-with-generic-graph branch from 8895977 to a93f22f Compare July 2, 2023 21:06
@simonschoelly simonschoelly mentioned this pull request Jun 29, 2023
12 tasks
@gdalle gdalle added the enhancement New feature or request label Jul 3, 2023
@simonschoelly simonschoelly force-pushed the test-community-with-generic-graph branch from a93f22f to c394936 Compare July 4, 2023 22:21
@simonschoelly simonschoelly removed the do not merge Do not merge this PR (yet) label Jul 5, 2023
@simonschoelly simonschoelly force-pushed the test-community-with-generic-graph branch from c394936 to 6c858eb Compare July 5, 2023 10:37
@gdalle gdalle merged commit 27d9763 into JuliaGraphs:master Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants