-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Kruskal traversal iterator #336
Open
Tortar
wants to merge
1
commit into
JuliaGraphs:master
Choose a base branch
from
Tortar:patch-2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
# The kruskal algorithms are largely copied from Graphs/src/spanningtrees/kruskal.jl | ||
|
||
struct KruskalIterator <: EdgeIterator | ||
graph::AbstractGraph | ||
connected_vs::IntDisjointSets | ||
distmx::AbstractMatrix | ||
edge_list | ||
|
||
function KruskalIterator(graph, distmx=weights(g); minimize=true) | ||
is_directed(graph) && throw(ArgumentError("Cannot use Kruskal on a directed graph.")) | ||
weights = Vector{eltype(distmx)}() | ||
sizehint!(weights, ne(graph)) | ||
edge_list = collect(edges(graph)) | ||
for e in edge_list | ||
push!(weights, distmx[src(e), dst(e)]) | ||
end | ||
e = edge_list[sortperm(weights; rev=!minimize)] | ||
new(graph, IntDisjointSets(nv(graph)), distmx, e) | ||
end | ||
end | ||
|
||
Base.length(t::KruskalIterator) = nv(t.graph)-1 | ||
Base.eltype(t::KruskalIterator) = edgetype(t.graph) | ||
|
||
|
||
""" | ||
mutable struct KruskalIteratorState | ||
`KruskalIteratorState` is a struct to hold the current state of iteration which is need for the Base.iterate() function. | ||
""" | ||
mutable struct KruskalIteratorState <: AbstractIteratorState | ||
edge_id::Int | ||
mst_len::Int | ||
end | ||
Comment on lines
+30
to
+33
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What is the advantage of having a mutable iterator state here? Couldn't we simply return a new state? |
||
|
||
|
||
function Base.iterate(t::KruskalIterator, state::KruskalIteratorState=KruskalIteratorState(1,1)) | ||
while state.mst_len <= (nv(t.graph)-1) | ||
i = state.edge_id | ||
if !in_same_set(t.connected_vs, src(t.edge_list[i]), dst(t.edge_list[i])) | ||
union!(t.connected_vs, src(t.edge_list[i]), dst(t.edge_list[i])) | ||
state.mst_len += 1 | ||
return (t.edge_list[i], state) | ||
end | ||
state.edge_id += 1 | ||
end | ||
end |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that true in case the graph is not connected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you are completely correct, but I don't have time to work on this at the moment, instead I would be willing to finish up #163, if you happen to have some review time I think it could be better to redirect it there :-)
(by the way I think also the other PR suffer from the same problem)