Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1900 - Add type parameters for zonotope #2029

Merged
merged 14 commits into from
Mar 12, 2020
Merged

#1900 - Add type parameters for zonotope #2029

merged 14 commits into from
Mar 12, 2020

Conversation

mforets
Copy link
Member

@mforets mforets commented Feb 29, 2020 •
edited
Loading

Closes #1900.

@mforets mforets changed the title WIP #1900 - Add type parameters for zonotope #1900 - Add type parameters for zonotope Mar 1, 2020
@mforets mforets changed the title #1900 - Add type parameters for zonotope WIP #1900 - Add type parameters for zonotope Mar 2, 2020
@mforets mforets changed the title WIP #1900 - Add type parameters for zonotope #1900 - Add type parameters for zonotope Mar 2, 2020
@mforets mforets requested a review from schillic March 2, 2020 07:34
schillic
schillic requested changes Mar 2, 2020
View reviewed changes
src/Sets/Zonotope.jl Outdated Show resolved Hide resolved
src/Sets/Zonotope.jl Outdated Show resolved Hide resolved
@mforets mforets requested a review from schillic March 2, 2020 07:58
schillic
schillic reviewed Mar 2, 2020
View reviewed changes
Copy link
Member

@schillic schillic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is now a problem with the reachability example in the manual. So we should check whether Reachability still works with this changeset.

src/convert.jl Outdated Show resolved Hide resolved
@mforets
Copy link
Member Author

mforets commented Mar 2, 2020

So we should check whether Reachability still works with this changeset.

i've opened JuliaReach/Reachability.jl#747. fwiw, i don't plan to work on this any time soon though; although i'm fine to review... i'm writing the adapted algorithms in ReachabilityAnalysis.jl

mforets
mforets commented Mar 3, 2020
View reviewed changes
docs/src/lib/conversion.md Outdated Show resolved Hide resolved
mforets
mforets commented Mar 3, 2020
View reviewed changes
docs/src/lib/conversion.md Outdated Show resolved Hide resolved
@mforets mforets merged commit e34ec1f into master Mar 12, 2020
@mforets mforets deleted the mforets/1900b branch March 12, 2020 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schillic schillic schillic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add type parameters for zonotope center and generators
2 participants
@mforets @schillic