Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Real instead of AbstractFloat #648

Closed
wants to merge 132 commits into from
Closed

Use Real instead of AbstractFloat #648

wants to merge 132 commits into from

Conversation

amontoison
Copy link
Member

@amontoison amontoison commented Oct 4, 2022 •
edited
Loading

amontoison and others added 30 commits September 7, 2022 13:54
@amontoison
[KrylovSolvers] inner constructors -> outer constructors
ad1fab9
@amontoison
Add a reference to BiCG paper
7c5e233
@amontoison
Update src/bilq.jl
3cc80c6
@amontoison
[documentation] Add a section about preconditioners
69e7c1d
@amontoison
Add more details about preconditioned LS and LN problems
cce31e6
@amontoison
[documentation] Add more details about preconditioners
58a28db
@amontoison
Final version of preconditioners.md
08c0e1e
@amontoison
Fix tests with CGNE
016d6c6
@amontoison @dpo
Apply suggestions from @dpo
5d1a87f 
Co-authored-by: Dominique <dominique.orban@gmail.com>
@amontoison
Update test_solvers.jl
5d54847
@amontoison
Update preconditioners.md
c967453
@amontoison
fix \tfrac in preconditioners.jl
55cbe4e
@amontoison @dpo
Update docs/src/preconditioners.md
dd42770 
Co-authored-by: Dominique <dominique.orban@gmail.com>
@amontoison
A^T -> A^H
645e094
@amontoison
[documentation] Use Aᴴ instead of Aᵀ
330304a
@amontoison
[test] Use Aᴴ instead of Aᵀ
604c960
@amontoison
[code] Use Aᴴ instead of Aᵀ
73e95a7
@amontoison
Test Krylov macros
fc8677b
@amontoison
Use buildkite to test the GPU support
e7cd9b8
@amontoison
Update workflows
fc8bb59
@amontoison
Update CommentPR.yml
26c4856
@amontoison
[documentation] update gpu.md
b19c74b
@amontoison
[documentation] Test the code of GPU backends with buildkite
3c67dfb
@amontoison
Fix few typos
a97909a
@amontoison @dpo
Apply suggestions from code review
b5c2ea9 
Co-authored-by: Dominique <dominique.orban@gmail.com>
@amontoison
[GPU] Remove random tests
bcbc6aa
@amontoison
Add more examples with the preconditioners
db3520f
@amontoison
Update docs/src/preconditioners.md
6208825
@amontoison
Release 0.8.4
66e1fd1
@amontoison
[documentation] update callbacks.md
794483b
amontoison and others added 20 commits November 24, 2022 23:58
@amontoison
Remove duplicate tolerances in MINRES
1dbe269
@amontoison
Add rtol in LSLQ
4dfbe15
@amontoison
Add documentation for all Keyword arguments
92bc8d6
@amontoison
Update MINRES and MINRES-QLP
243425e
@amontoison
Check all docstrings
566f23e
@amontoison
Release 0.9.0
338dbc4
@amontoison
Update CI for aarch64 Mac -- Apple M1
3758132
@amontoison
Add an example with BasicLU.jl in preconditioners.md
e965ad5
@amontoison
Use Cirrus to test Krylov.jl with Apple M1
12b4ab6
@maleadt @amontoison
Switch Metal.jl CI to the juliaecosystem pipeline.
5291caf
@amontoison
Use JET to fix bugs and type instabilities
0e3de13
@amontoison
Add new tests for GPUs
962811e
@amontoison
Use sparse_laplacian instead of symmetric_indefinite for GPU tests
9e4b6da
@amontoison
[buildkite] Use Julia 1.9 for AMD GPUs
03ee0a8
@amontoison
Use symmetric_definite instead of sparse_laplacian for GPU tests
baa45b3
@amontoison
Debug minres_qlp with verbose mode
67dbbee
@amontoison
Relax the tolerance of the stopping condition based on the backward e…
18ef839 
…rror
@amontoison
Use master branch of AMDGPU.jl
391da90
@amontoison
Use Real instead of AbstractFloat
e0abd0f
@amontoison
Update Krylov solvers
66f3059
@amontoison
Copy link
Member Author

To have rtol (and possibly other parameters) as T in this context feels counterintuitive. I understand that you want to be able e.g. BigFloat. So may be a Union could do here ?

Yes, I agree with you, but for type-stability it's better to keep it.
From my point of view, we should overload the eps of ForwardDiff to also return a Dual.

@amontoison amontoison closed this Oct 14, 2024
@amontoison amontoison deleted the abstractfloat_real branch October 14, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@amontoison @dpo @j-fu @JuliaRegistrator @tmigot @maleadt