Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix preconditioning in cg when optional radius argument is positive #868

Merged
merged 5 commits into from
Aug 5, 2024
Merged

Fix preconditioning in cg when optional radius argument is positive #868

merged 5 commits into from
Aug 5, 2024

Commits on May 21, 2024

  1. Add preconditioning to to_boundary

    @mpf
    mpf committed May 21, 2024
    Configuration menu
    Copy the full SHA
    6e97d0a View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. Merge branch 'JuliaSmoothOptimizers:main' into Preconditioning

    @mpf
    mpf authored May 30, 2024
    Configuration menu
    Copy the full SHA
    27363d4 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2024

  1. Fix to_boundary unit tests. 

    Note the new 4th argument z, which is a vector that provides workspace for the mul! (or ldiv!) operations on the preconditioner. This isn't needed when M=I`.

Because z is modified in place, probably the function should be renamed to to_boundary! (add exclamation).
    @mpf
    mpf committed May 31, 2024
    Configuration menu
    Copy the full SHA
    42cda9e View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2024

  1. Update the arguments of to_boundary

    @amontoison
    amontoison committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    49ee594 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2024

  1. Merge pull request #1 from amontoison/mpf-hotfix 

    Update the arguments of to_boundary
    @mpf
    mpf authored Aug 5, 2024
    Configuration menu
    Copy the full SHA
    e996da2 View commit details
    Browse the repository at this point in the history