WIP: Add generic friends to KingMaker, refactor tasks, rework building of tarballs #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrypuuter
requested review from
conformist89,
winterchristian,
nshadskiy,
a-monsch and
ralfschmieder
|
It looks good to me |
a-monsch
reviewed
Sep 8, 2023
processor/tasks/CROWNBase.py
Outdated
| # sanitize the scopes information | ||
| try: | ||
| self.scopes = ast.literal_eval(str(self.scopes)) | ||
| except: |
There was a problem hiding this comment.
Wouldn't it be beneficial to state the expected errors explicitly/use contextlib.suppress if no change is applied in case of occurring Exception?
There was a problem hiding this comment.
I rewrote the function to be much simpler :D
a-monsch
reviewed
Sep 8, 2023
processor/tasks/CROWNBase.py
Outdated
| # sanitize the shifts information | ||
| try: | ||
| self.shifts = ast.literal_eval(str(self.shifts)) | ||
| except: |
There was a problem hiding this comment.
Wouldn't it be beneficial to state the expected errors explicitly/use contextlib.suppress if no change is applied in case of occurring Exception?
a-monsch
reviewed
Sep 8, 2023
a-monsch
reviewed
Sep 8, 2023
|
If you are happy with the PR, please set an approve @conformist89 @a-monsch |
a-monsch
approved these changes
Sep 11, 2023
conformist89
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.