Skip to content

Commit

Permalink
Fix/31 (#51)
Browse files Browse the repository at this point in the history
fix #31
  • Loading branch information
mvanbrab authored Jan 7, 2021
1 parent a76acea commit 2750861
Show file tree
Hide file tree
Showing 3 changed files with 32 additions and 1 deletion.
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Update dependencies

### Fixed
- Filter query/path parameters before substituting variables (see [issue 36](https://github.com/KNowledgeOnWebScale/walder/issues/36))
- Filter query/path parameters before substituting variables (see [issue 36](https://github.com/KNowledgeOnWebScale/walder/issues/36))
- 404 error on /favicon.ico in examples (see [issue 31](https://github.com/KNowledgeOnWebScale/walder/issues/31))

## [2.0.3] - 2020-08-31

Expand Down
Binary file added example/public/favicon.ico
Binary file not shown.
30 changes: 30 additions & 0 deletions test/example/test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
require('chai').should();
const request = require('supertest');
const path = require('path');
const Walder = require('../../lib/walder');

const CONFIG_FILE = '../../example/config.yaml';

describe('Example', function () {

describe('# Favicon', function () {
before('Activating Walder', function () {
const configFile = path.resolve(__dirname, CONFIG_FILE);
const port = 9000;

this.walder = new Walder(configFile, {port, logging:'error'});
this.walder.activate();
});

after('Deactivating Walder', function () {
this.walder.deactivate();
});

it('should serve /favicon.ico', function (done) {
request(this.walder.app)
.get('/favicon.ico')
.expect(200)
.end(done);
});
});
});

0 comments on commit 2750861

Please sign in to comment.