respond to RFCs in PR nucypher#297

KPrasch · Aug 7, 2024 · 18785e8 · 18785e8
1 parent 646e3eb
commit 18785e8
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/deployment/constants.py b/deployment/constants.py
@@ -59,7 +59,7 @@
 # Sampling
 #
 
-PORTER_ENDPOINTS = {
+PORTER_SAMPLING_ENDPOINTS = {
     MAINNET: "https://porter.nucypher.io/bucket_sampling",
     LYNX: "https://porter-lynx.nucypher.io/get_ursulas",
     TAPIR: "https://porter-tapir.nucypher.io/get_ursulas",

diff --git a/deployment/utils.py b/deployment/utils.py
@@ -9,7 +9,7 @@
 from ape.contracts import ContractContainer, ContractInstance
 from ape_etherscan.utils import API_KEY_ENV_KEY_MAP
 
-from deployment.constants import ARTIFACTS_DIR, LYNX, MAINNET, PORTER_ENDPOINTS, TAPIR
+from deployment.constants import ARTIFACTS_DIR, LYNX, MAINNET, PORTER_SAMPLING_ENDPOINTS, TAPIR
 from deployment.networks import is_local_network
 
 
@@ -162,7 +162,7 @@ def registry_filepath_from_domain(domain: str) -> Path:
 def sample_nodes(
     domain: str, num_nodes: int, random_seed: Optional[int] = None, duration: Optional[int] = None
 ):
-    porter_endpoint = PORTER_ENDPOINTS.get(domain)
+    porter_endpoint = PORTER_SAMPLING_ENDPOINTS.get(domain)
     if not porter_endpoint:
         raise ValueError(f"Porter endpoint not found for domain '{domain}'")
 

diff --git a/scripts/initiate_ritual.py b/scripts/initiate_ritual.py
@@ -85,7 +85,7 @@ def cli(
     if not (bool(handpicked) ^ (num_nodes is not None)):
         raise click.BadOptionUsage(
             option_name="--num-nodes",
-            message=f"Specify either --num-nodes or --handpicked; got {num_nodes} {handpicked}",
+            message=f"Specify either --num-nodes or --handpicked; got {num_nodes}, {handpicked}.",
         )
     if handpicked and random_seed:
         raise click.BadOptionUsage(