Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: add merkle root to tendermint bundle summary #137

Merged
merged 8 commits into from
Jun 17, 2024

Conversation

christopherbrumm
Copy link
Member

This PR updates the @kyvejs/tendermint runtime with the Merkle root that is required for the Trustless API integration.

Copy link
Member

@troykessler troykessler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we move merkle.ts into @kyvejs/sdk or @kyvejs/protocol? since other runtimes like @kyvejs/tendermint-bsync also want to use the same logic

@christopherbrumm
Copy link
Member Author

should we move merkle.ts into @kyvejs/sdk or @kyvejs/protocol? since other runtimes like @kyvejs/tendermint-bsync also want to use the same logic

Only generateMerkleRoot could be reused for all runtimes. dataItemToSha256 and createHashesFromBundle are runtime specific. We could create an interface that implements the core logic with dataItemToSha256 just hashing the whole data item, whereas other runtimes can overwrite this function due to more granular hashing.

@troykessler troykessler self-requested a review June 13, 2024 14:28
@troykessler troykessler changed the base branch from main to release/v1.5.x June 13, 2024 14:47
@troykessler troykessler force-pushed the cbrumm/tendermint-merkle-root branch from f8102e4 to 9cec726 Compare June 14, 2024 12:47
@troykessler troykessler merged commit 05cdca3 into release/v1.5.x Jun 17, 2024
3 checks passed
@troykessler troykessler deleted the cbrumm/tendermint-merkle-root branch June 17, 2024 07:06
troykessler added a commit that referenced this pull request Jul 3, 2024
* feat: generated new types for v1.5

* chore: updated amino types for v1.5

* chore: completed 1.5 implementation

* chore: updated types and sdk

* feat: add end-key to pool (#133)

* chore: generate new lcd/client

* feat: skipUploaderRole when endKey is reached

* chore: add tests

* chore: properly implemented end key on protocol node

* fix: yarn.lock

---------

Co-authored-by: Troy Kessler <troy.kessler99@gmail.com>

* chore: moved v1 endpoints to correct path

* chore: added flag for data availability check (#120)

* chore: added flag for data availability check

* chore: added better logs

* chore: add property for injective

* chore: removed unused deps

* chore: removed more unused deps

* fix: build

* update: add merkle root to tendermint bundle summary (#137)

* update: add merkle root to tendermint bundle summary

* update: add merkle.ts to sdk

* chore: kyvejs/sdk

* fix: lint errors

* chore: added merkle root summary to tendermint-bsync

---------

Co-authored-by: Troy Kessler <troy.kessler99@gmail.com>

* fix: support cometbft v0.38 block_results schema (#130)

* fix: support cometbft v0.38 block_results schema

* chore: added strict checks for begin and finalize block events

* chore: added check for mode attributes

* chore: added comments

---------

Co-authored-by: Raphael <raphael.thurnherr1990@gmail.com>
Co-authored-by: Christopher Brumm <97845034+christopherbrumm@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants