Skip to content

Commit

Permalink
Fix clippy lints (#316)
Browse files Browse the repository at this point in the history
  • Loading branch information
jayvdb authored Oct 5, 2024
1 parent 8893c44 commit 81a9fc3
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 13 deletions.
4 changes: 2 additions & 2 deletions full-moon/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ keywords = ["lua", "parser", "lua51", "lua52", "luau"]
edition = "2021"

[package.metadata.docs.rs]
# Build Locally: RUSTDOCFLAGS="--cfg doc_cfg" cargo +nightly doc --features luau,lua52,lua53,lua54,luajit --no-deps --open
# Build Locally: RUSTDOCFLAGS="--cfg docsrs" cargo +nightly doc --features luau,lua52,lua53,lua54,luajit --no-deps --open
features = ["luau", "lua52", "lua53", "lua54", "luajit"]
rustdoc-args = ["--cfg", "doc_cfg"]
rustdoc-args = ["--cfg", "docsrs"]

[features]
default = ["serde"]
Expand Down
2 changes: 1 addition & 1 deletion full-moon/src/ast/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ use lua54::*;
#[display(
"{}{}",
display_optional_punctuated_vec(stmts),
display_option(&last_stmt.as_ref().map(display_optional_punctuated))
display_option(last_stmt.as_ref().map(display_optional_punctuated))
)]
pub struct Block {
stmts: Vec<(Stmt, Option<TokenReference>)>,
Expand Down
17 changes: 9 additions & 8 deletions full-moon/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#![warn(missing_docs)]
#![allow(clippy::large_enum_variant)]
#![cfg_attr(doc_cfg, feature(doc_auto_cfg))]
#![cfg_attr(docsrs, feature(doc_auto_cfg))]
//! # Full Moon
//!
//! `full_moon` is a lossless parser for Lua, supporting Lua 5.1, 5.2, 5.3, 5.4 and Luau
Expand Down Expand Up @@ -95,16 +95,17 @@ pub fn parse(code: &str) -> Result<ast::Ast, Vec<Error>> {

/// Given code and a pinned Lua version, will produce an [`ast::AstResult`].
/// This AstResult always produces some [`Ast`](ast::Ast), regardless of errors.
/// If a partial Ast is produced (i.e. if there are any errors), a few guarantees are lost.
/// If a partial Ast is produced (i.e. if there are any errors), a few guarantees are lost:
///
/// 1. Tokens may be produced that aren't in the code itself. For example, `if x == 2 code()`
/// will produce a phantom `then` token in order to produce a usable [`If`](ast::If) struct.
/// These phantom tokens will have a null position. If you need accurate positions from the
/// phantom tokens, you can call [`Ast::update_positions`](ast::Ast::update_positions).
/// will produce a phantom `then` token in order to produce a usable [`If`](ast::If) struct.
/// These phantom tokens will have a null position. If you need accurate positions from the
/// phantom tokens, you can call [`Ast::update_positions`](ast::Ast::update_positions).
/// 2. The code, when printed, is not guaranteed to be valid Lua.
/// This can happen in the case of something like `local x = if`, which will produce a
/// [`LocalAssignment`](ast::LocalAssignment) that would print to `local x =`.
/// This can happen in the case of something like `local x = if`, which will produce a
/// [`LocalAssignment`](ast::LocalAssignment) that would print to `local x =`.
/// 3. There are no stability guarantees for partial Ast results, but they are consistent
/// within the same exact version of full-moon.
/// within the same exact version of full-moon.
pub fn parse_fallible(code: &str, lua_version: LuaVersion) -> ast::AstResult {
ast::AstResult::parse_fallible(code, lua_version)
}
Expand Down
6 changes: 4 additions & 2 deletions full-moon/src/tokenizer/structs.rs
Original file line number Diff line number Diff line change
Expand Up @@ -914,8 +914,9 @@ impl fmt::Display for TokenizerError {

impl std::error::Error for TokenizerError {}

// #[cfg(test)]
#[cfg(feature = "rewrite todo: tokenizer tests")]
/*
// rewrite TODO: tokenizer tests
mod tests {
use crate::tokenizer::*;
use pretty_assertions::assert_eq;
Expand Down Expand Up @@ -1193,3 +1194,4 @@ mod tests {
let _ = tokens("¹;");
}
}
*/

0 comments on commit 81a9fc3

Please sign in to comment.