-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The print()
function didn't print
#308
Conversation
CHANGELOG.md
Outdated
@@ -7,6 +7,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
## [1.0.0-rc.5] - 2024-07-06 | |||
### Changed | |||
- **[BREAKING CHANGE]** The `types` module is now named `luau`. | |||
- **[BREAKING CHANGE]** The `print()` function has been removed, use `ast.to_string()` instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put this in a new "Unreleased" section with no date
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Apologies for delays :) Looks like a trivial |
Done, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the clippy errors (which can be fixed using PR #316), this PR makes sense.
Although it does break compatibility.
The
print(ast
) function didn't print anything, it merely formatted theAst
as a string. This was confusing.To make it more clear the function has been replaced by an implementation of
Display
forAst
that has the same formatting behavior.