Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The print() function didn't print #308

Merged
merged 7 commits into from
Oct 9, 2024
Merged

Conversation

softdevca
Copy link
Contributor

The print(ast) function didn't print anything, it merely formatted the Ast as a string. This was confusing.

To make it more clear the function has been replaced by an implementation of Display for Ast that has the same formatting behavior.

CHANGELOG.md Outdated
@@ -7,6 +7,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## [1.0.0-rc.5] - 2024-07-06
### Changed
- **[BREAKING CHANGE]** The `types` module is now named `luau`.
- **[BREAKING CHANGE]** The `print()` function has been removed, use `ast.to_string()` instead.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put this in a new "Unreleased" section with no date

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@Kampfkarren
Copy link
Owner

Apologies for delays :) Looks like a trivial cargo fmt is all this needs now

@softdevca
Copy link
Contributor Author

Apologies for delays :) Looks like a trivial cargo fmt is all this needs now

Done, thanks!

Copy link
Contributor

@DataM0del DataM0del left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the clippy errors (which can be fixed using PR #316), this PR makes sense.
Although it does break compatibility.

@Kampfkarren Kampfkarren merged commit fd6cb46 into Kampfkarren:main Oct 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants