Fix including trivia in check for typeof identifier #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnnyMorganz
approved these changes
Oct 2, 2024
full-moon/tests/roblox_cases/pass/multiline_typeof_regression/ast.snap
Outdated
Show resolved
Hide resolved
JohnnyMorganz
approved these changes
Oct 3, 2024
|
@JohnnyMorganz The tests should be all good now, I had forgot to update |
DataM0del
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #314
The following case will fail to parse correctly because the check at this line includes all trivia. When including the trivia, we end up with a check that looks like
" typeof" = "typeof", which of course fails.This PR turns the token into a string instead of the token reference in the check, as the token does not contain trivia.