Skip to content

Fix for slicing in case of dynamic taclet applications and renamings - #3981

Open
unp1 wants to merge 4 commits into
mainfrom
bubel/fix-dynamic-taclet-replace-slicing
Open

Fix for slicing in case of dynamic taclet applications and renamings#3981
unp1 wants to merge 4 commits into
mainfrom
bubel/fix-dynamic-taclet-replace-slicing

Conversation

@unp1

@unp1 unp1 commented Aug 23, 2026

Copy link
Copy Markdown
Member

Intended Change

Analysing whether some proofs from the StipuLa case study can be made smaller using slicing,
an exception was encountered concerning a dynamically loaded taclet could not be found.

The reasons was that the replay for slicing omitted to also check the locally introduced taclet information
in nodes. Adding this revealed a second problem with renaming (taclets with addprogvars).

Both issues have been fixed.

Added also the StipuLa case study problems and a test for slicing.

Type of pull request

  • Bug fix (non-breaking change which fixes an issue)
  • There are changes to the (Java) code

Ensuring quality

  • I made sure that introduced/changed code is well documented (javadoc and inline comments).
  • I added new test case(s) for new functionality.
  • I have tested the feature as follows: slicing tests, standard tests by CI

Additional information and contact(s)

The contributions within this pull request are licensed under GPLv2 (only) for inclusion in KeY.

unp1 added 3 commits August 23, 2026 13:40
…il to find a dynamically introduced taclet that changed it name due to slicing
…lications causes renamings of (not related) formulas
@unp1
unp1 requested a review from WolframPfeifer August 23, 2026 13:33
@unp1 unp1 self-assigned this Aug 23, 2026
@unp1 unp1 added the 🐞 Bug label Aug 23, 2026
@unp1 unp1 added this to the v3.1.0 milestone Aug 23, 2026
@unp1
unp1 force-pushed the bubel/fix-dynamic-taclet-replace-slicing branch 3 times, most recently from 421a77d to 8e11851 Compare August 23, 2026 14:02
@unp1
unp1 force-pushed the bubel/fix-dynamic-taclet-replace-slicing branch from 8e11851 to 968772c Compare August 23, 2026 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant