Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix tests on macOS #81

Closed
wants to merge 4 commits into from
Closed

fix tests on macOS #81

wants to merge 4 commits into from

Commits on Aug 16, 2024

  1. fix tests on macOS 

    The tests assume that the config dir is ~/.config and the data dir is
~/.local/share. Neither is true on macOS, and this causes several tests
to fail:

	FAILED tests/test_emborg.py::test_emborg_without_configs[4] - AssertionError: Test ‘labor’ fails.
	FAILED tests/test_emborg.py::test_emborg_with_configs[5] - AssertionError: Test ‘periphery’ fails.
	FAILED tests/test_emborg.py::test_emborg_with_configs[25] - AssertionError: Test ‘build’ fails.
	FAILED tests/test_emborg.py::test_emborg_overdue[1] - AssertionError: Test ‘predator’ fails.
	FAILED tests/test_emborg.py::test_emborg_overdue[2] - AssertionError: Test ‘smelt’ fails.

Rather than changing the tests to dynamically use different test paths
based on the OS[1], it's simpler to change emborg's behavior at test
time to always use the Linux paths. That is what this change does.

Also adds tests/Users to .gitignore, which is the macOS equivalent of
tests/home.

[1] This was in fact the first thing I tried. But as I got into it the
    added complexity didn't seem justified.
    @jeremyschlatter
    jeremyschlatter committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    a4615ea View commit details
    Browse the repository at this point in the history

  2. fix macOS tests by changing the tests, not the exe

    @jeremyschlatter
    jeremyschlatter committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    afcabe5 View commit details
    Browse the repository at this point in the history

  3. delete redundant import

    @jeremyschlatter
    jeremyschlatter committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    25c3b30 View commit details
    Browse the repository at this point in the history

  4. delete unused import

    @jeremyschlatter
    jeremyschlatter committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    3facafd View commit details
    Browse the repository at this point in the history