Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made clonestamp brush clone blocks only above the target block (but including the target itself) #242

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

Lennart99
Copy link
Collaborator

@Lennart99 Lennart99 commented Sep 16, 2024

What type of PR is this? (check all applicable)

  • Feature
  • Refactor
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Changes clonestamp brush to be more useful in practise, making the tagret block the 'start' point instead of the center-block.
https://discord.com/channels/733237907040632924/981234987451944970/1284865473728745493

QA Instructions, Screenshots, Recordings

tested on spigot 1.20.1

Added/updated tests?

  • Yes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests
  • Not needed

[optional] What gif best describes this PR or how it makes you feel?

alt_text

Copy link
Owner

@KevinDaGame KevinDaGame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess I'm this person now, but could you add a little documentation? https://github.com/KevinDaGame/VoxelSniper-Reimagined/wiki/brushes#clone-brush 😁

@Lennart99
Copy link
Collaborator Author

Updated the documentation

@KevinDaGame
Copy link
Owner

Updated the documentation

Looks good. Just missing a usage example (how to type the command) with the modes

@Lennart99
Copy link
Collaborator Author

@KevinDaGame Added that as well.

Copy link
Owner

@KevinDaGame KevinDaGame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a little remark

@Lennart99 Lennart99 merged commit fa74a77 into master Sep 18, 2024
1 check passed
@Lennart99 Lennart99 deleted the fix/clonestamp branch September 18, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants