253 Raise a visible error in the border case where no error message is available #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tramora
changed the title
tramora
force-pushed
the
253-raise-exception-no-error-message
branch
from
187c0a4
to
b0c563e
Compare
… message is available
tramora
force-pushed
the
253-raise-exception-no-error-message
branch
from
7d57977
to
c8c23f5
Compare
folmos-at-orange
approved these changes
Oct 18, 2024
| if return_code != 0: | ||
| raise KhiopsRuntimeError( | ||
| f"{tool_name} execution had errors (return code {return_code}) " | ||
| "but no message is available\n" |
| @@ -746,6 +746,13 @@ def _report_exit_status( | |||
| f"Khiops ended correctly but there were minor issues:\n{error_msg}" | |||
| ) | |||
| warnings.warn(error_msg.rstrip()) | |||
| else: | |||
| # no message available, an error must be raised though | |||
There was a problem hiding this comment.
I'd put Raise an exception anyway for a non-zero return code with no messages
Comment on lines
+2699
to
+2701
| False, # ask for an empty stdout | ||
| False, # ask for an empty stderr | ||
| 9, # non-zero error code |
There was a problem hiding this comment.
You can use named parameters to self document:
create_mocked_raw_run(
stdout=False,
stderr=False,
return_code=9
)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #253