Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle problems caused by runner and Docker image updates #933

Merged
merged 8 commits into from
Sep 6, 2024

Conversation

MarkCallow
Copy link
Collaborator

@MarkCallow MarkCallow commented Aug 27, 2024

An Emscripten Docker image update to Clang 20 and an update to the GitHub Actions Windows runner image broke our CI builds. This PR provides fixes or workarounds. While working on the Clang 20 issue it was noticed that the FP options for libktx were not being set as intended, except for the ASTC encoder. This PR also fixes that problem so the same FP options are used throughout libktx. Lastly it contains improvements to build_wasm_docker.sh made while debugging and fixing the FP settings issue.

clang 20 has a new "overriding option" warning which is raised if one float-point option modifies a setting made by another. We are setting -ffp-model=precise, which leaves contraction on, and -ffp-contract=off thus we get the warning. This usage is normal for cross-platform invariance thus the fix is to disable the spam warning.

The Windows runner image update broke the python build due to removal of a long deprecated package from the Python/PIP setuptools package and our use of the cffi package which has a dependency on setuptools including the deleted package. See python-cffi/cffi#117. This PR works around the problem by creating a constraint.txt file which is passed to PIP and tells it to limit the setuptools package to a version that still contains the deleted package.

@MarkCallow MarkCallow changed the title Fix FP settings and turn off spam warning from clang 20. Handle problems caused by runner and Docker image updates Sep 4, 2024
@MarkCallow MarkCallow merged commit da4755f into main Sep 6, 2024
18 checks passed
@MarkCallow MarkCallow deleted the clang20_workaround branch September 6, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant