Fix: ensure ktxdiff runs on macOS and enable CTS in Linux arm64 CI. #946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
INSTALL_RPATH was not being set meaning macOS could not find libktx. Since cts tests succeeded on CI, which runs on x86_64, assumption is the failure was caused by stricter run time checks on Apple Silicon.
MarkCallow
changed the title
MarkCallow
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set INSTALL_RPATH in
ktxdiff. Its absence meant macOS could not find libktx, if not installed on the system. Tests were succeeding on macOS x86_64 because all the outputs are exact matches for the golden files soktxdiffwas never invoked.Enable FEATURE_TOOLS_CTS for Linux arm64 build as KhronosGroup/KTX-Software-CTS#30 fixes the previous failure.
Fix syntax errors in Linux INSTALL_RPATH values.